1240714 - Incorrect invalidation of an image

Status: RESOLVED WORKSFORME

(Core :: Web Painting, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: bug.png

Looking at bbouvier pictures, I had some repaint issue. Nical confirmed that it is a firefox issue.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Matt, Nical said that you should know!

Comment 3

[Timothy Nikkel (:tnikkel)]

Is there a url where one can reproduce this issue?

Comment 4

[Matt Woodrow (:mattwoodrow)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #2)
> Matt, Nical said that you should know!

Throwing me in the deep end again!

I don't recognise this as any open bug that I know of.

Is this reproducible? What are the STR?

Adding Seth to the cc list since it's likely an imagelib issue.

Comment 5

[Matt Woodrow (:mattwoodrow)]

I can't reproduce this unfortunately.

Nical, does disabling accelerated layers help you reproduce this?

Bug 1240073 seems quite similar.

Comment 6

[Nicolas Silva [:nical]]

I reproduced the bug with the basic compositor and applying the patch in Bug 1240073 doesn't help at all (it's probably even worse).

Comment 7

[Nicolas Silva [:nical]]

I think that the damaged region isn't tracked properly on the basic compositor. I changed BasicCompositor::BeginFrame to invalidate the enire window every time and the bug disappears.

Comment 8

[Timothy Nikkel (:tnikkel)]

I can reproduce on mac with basic compositor too.

Comment 9

[Matt Woodrow (:mattwoodrow)]

I was on BasicCompositor and couldn't reproduce :(

Could someone try stepping through LayerPropertiesBase::ComputeDifferences and see why we aren't invalidating a large enough area?

Comment 10

[Timothy Nikkel (:tnikkel)]

Now I can't reproduce :(

Comment 11

[Jet Villegas (inactive)]

Sylvestre: is it also WORKSFORME on your side?

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Benjamin, did you update your instance?

Comment 13

[Benjamin Bouvier [:bbouvier] (inactive)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #12)
> Benjamin, did you update your instance?

I have not, why?

Comment 14

[Sylvestre Ledru [:Sylvestre]]

Works for me now, not sure what changed...