Closed
Bug 1240767
Opened 5 years ago
Closed 5 years ago
Running 'mach robocop' with wrong test name runs all tests
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(firefox46 fixed)
RESOLVED
FIXED
Firefox 46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: sebastian, Assigned: gbrown)
Details
Attachments
(1 file)
1.79 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Running 'mach robocop' with a mistype test name seems to run ALL tests:
> ./mach robocop testBanana
Reporter | ||
Comment 1•5 years ago
|
||
This is especially confusing if you type the correct name but the test is not listed in robocop.ini :)
![]() |
Assignee | |
Updated•5 years ago
|
Assignee: nobody → gbrown
![]() |
Assignee | |
Comment 2•5 years ago
|
||
'mach mochitest' handles bad test paths; I modelled the robocop solution on that. Now: $ ./mach robocop testBanana From _tests: Kept 20009 existing; Added/updated 0; Removed 0 files and 0 directories. The robocop command could not find any tests under the following test path(s): testBanana Please check spelling and make sure the named tests exist. 'mach robocop' and 'mach <valid-test-path>' continue to work as before.
Attachment #8709550 -
Flags: review?(jmaher)
Comment 3•5 years ago
|
||
Comment on attachment 8709550 [details] [diff] [review] print message if specified test path not found in manifest Review of attachment 8709550 [details] [diff] [review]: ----------------------------------------------------------------- I am not very familiar with this code, but it does look to be what would prevent us from running all.
Attachment #8709550 -
Flags: review?(jmaher) → review+
Comment 5•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/698919a8af16
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Updated•1 month ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•