1240767 - Running 'mach robocop' with wrong test name runs all tests

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

Running 'mach robocop' with a mistype test name seems to run ALL tests:
> ./mach robocop testBanana

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

This is especially confusing if you type the correct name but the test is not listed in robocop.ini :)

Comment 2

[Geoff Brown [:gbrown]]

Attachment: print message if specified test path not found in manifest

'mach mochitest' handles bad test paths; I modelled the robocop solution on that.

Now:

$ ./mach robocop testBanana
From _tests: Kept 20009 existing; Added/updated 0; Removed 0 files and 0 directories.
The robocop command could not find any tests under the following
test path(s):

testBanana

Please check spelling and make sure the named tests exist.


'mach robocop' and 'mach <valid-test-path>' continue to work as before.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8709550 [details] [diff] [review]
print message if specified test path not found in manifest

Review of attachment 8709550 [details] [diff] [review]:
-----------------------------------------------------------------

I am not very familiar with this code, but it does look to be what would prevent us from running all.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/698919a8af16

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/698919a8af16