Closed
Bug 1240806
Opened 10 years ago
Closed 10 years ago
GLContextEGL::CreateEGLPixmapOffscreenContext is dead code
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: nical, Assigned: nical)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1325019)
Attachments
(1 file)
|
2.75 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Found by coverity. The pixmap variable on the stack is initialized to 0 and used to be mutated by some X11 specific code that got removed in bug 814159. Immediately after that a branch early returns if pixmap == 0 which is now always true.
|
Assignee | |
Comment 1•10 years ago
|
||
The method is not even called.
Assignee: nobody → nical.bugzilla
Attachment #8709511 -
Flags: review?(jgilbert)
|
||
Updated•10 years ago
|
Attachment #8709511 -
Flags: review?(jgilbert) → review+
|
|
||
Comment 3•10 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
|
||
Updated•7 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•