Closed Bug 1240806 Opened 4 years ago Closed 4 years ago

GLContextEGL::CreateEGLPixmapOffscreenContext is dead code

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: nical, Assigned: nical)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1325019)

Attachments

(1 file)

Found by coverity. The pixmap variable on the stack is initialized to 0 and used to be mutated by some X11 specific code that got removed in bug 814159. Immediately after that a branch early returns if pixmap == 0 which is now always true.
Keywords: coverity
Whiteboard: CID 1325019
The method is not even called.
Assignee: nobody → nical.bugzilla
Attachment #8709511 - Flags: review?(jgilbert)
Attachment #8709511 - Flags: review?(jgilbert) → review+
https://hg.mozilla.org/mozilla-central/rev/bc1262de864a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.