1240857 - If a job is selected so that the bottom pane is open, clicking the 'v' button on a push takes two clicks to open the menu

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

STR:
1. Select a job so that the bottom panel opens.
2. Do NOT pin that job to the pinboard.
3. Try to click the menu button (next to the 'pin all jobs on this resultset' button) on any push.

The first time you click it, the bottom pane will close. You have to click it a second time to actually get the menu to open.

This doesn't happen for the "cancel all jobs" button or the "pin all jobs" button. Those actions happen on the first click and the bottom panel stays open.

I'd argue that the same should be true for the menu button (and any of the items inside the menu that you later click). The bottom panel should only close if you select a non-actionable part of the main TH UI.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:action-btn-ignore-clear > mozilla:master

Comment 2

[Jonathan French (:jfrench)]

Comment on attachment 8744477 [details] [review]
[treeherder] tojon:action-btn-ignore-clear > mozilla:master

PR for review at your leisure :)

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8744477 [details] [review]
[treeherder] tojon:action-btn-ignore-clear > mozilla:master

Thanks for fixing this, man!  Works fantastic for me.  :)

Comment 4

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5c746c993cdf069c973221706e6b0dc9a0b3a903
Bug 1240857 - Ignore job clear on majority of resultset action menu

https://github.com/mozilla/treeherder/commit/38097d176e454ce8a7be97a00454d9a3a7121576
Merge pull request #1421 from tojon/action-btn-ignore-clear

Bug 1240857 - Ignore job clear on majority of resultset action menu

Comment 5

[Jonathan French (:jfrench)]

Verified fixed on stage.