If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

If a job is selected so that the bottom pane is open, clicking the 'v' button on a push takes two clicks to open the menu

VERIFIED FIXED

Status

Tree Management
Treeherder
P4
normal
VERIFIED FIXED
2 years ago
a year ago

People

(Reporter: KWierso, Assigned: jfrench)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
STR:
1. Select a job so that the bottom panel opens.
2. Do NOT pin that job to the pinboard.
3. Try to click the menu button (next to the 'pin all jobs on this resultset' button) on any push.

The first time you click it, the bottom pane will close. You have to click it a second time to actually get the menu to open.

This doesn't happen for the "cancel all jobs" button or the "pin all jobs" button. Those actions happen on the first click and the bottom panel stays open.

I'd argue that the same should be true for the menu button (and any of the items inside the menu that you later click). The bottom panel should only close if you select a non-actionable part of the main TH UI.

Comment 1

a year ago
Created attachment 8744477 [details] [review]
[treeherder] tojon:action-btn-ignore-clear > mozilla:master
(Assignee)

Updated

a year ago
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
OS: Unspecified → All
Priority: -- → P4
Hardware: Unspecified → All
(Assignee)

Comment 2

a year ago
Comment on attachment 8744477 [details] [review]
[treeherder] tojon:action-btn-ignore-clear > mozilla:master

PR for review at your leisure :)
Attachment #8744477 - Flags: review?(cdawson)
Comment on attachment 8744477 [details] [review]
[treeherder] tojon:action-btn-ignore-clear > mozilla:master

Thanks for fixing this, man!  Works fantastic for me.  :)
Attachment #8744477 - Flags: review?(cdawson) → review+

Comment 4

a year ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5c746c993cdf069c973221706e6b0dc9a0b3a903
Bug 1240857 - Ignore job clear on majority of resultset action menu

https://github.com/mozilla/treeherder/commit/38097d176e454ce8a7be97a00454d9a3a7121576
Merge pull request #1421 from tojon/action-btn-ignore-clear

Bug 1240857 - Ignore job clear on majority of resultset action menu

Updated

a year ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Comment 5

a year ago
Verified fixed on stage.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.