1240867 - Compile errors due to missing includes

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

I add a new file to the gfx/layers unified build and it caused bustage:

c:/builds/moz2_slave/try-w32-mulet-0000000000000000/build/src/gfx/layers/client/ImageClient.cpp(326) : error C2664: 'void mozilla::layers::ShadowLayerForwarder::AttachAsyncCompositable(uint64_t,mozilla::layers::ShadowableLayer *)' : cannot convert argument 2 from 'mozilla::layers::ClientLayer *' to 'mozilla::layers::ShadowableLayer *'

ImageClient.cpp doesn't know that ClientLayer is a subclass of ShadowableLayer because all it has is the forward declaration in ImageClient.h

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

There's also this one:

c:/builds/moz2_slave/try-w32-mulet-0000000000000000/build/src/gfx/layers/opengl/OGLShaderProgram.cpp(165) : error C2065: 'CompositionOp' : undeclared identifier

because OGLShaderProgram.cpp isn't including gfx/2d/Types.h.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Another missing include

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8709591 [details] [diff] [review]
Part 2 - Another missing include

This one doesn't seem to fix the error for some reason. Stupid un-locally-reproducible unified build bustages :(

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 patch

Ok, here we go.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9b03a12ce6d
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7b536914def

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e9b03a12ce6d
https://hg.mozilla.org/mozilla-central/rev/b7b536914def