1240888 - prevent buildbot starting as root

Status: RESOLVED INCOMPLETE

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

We had some problems last week that were a result of buildbot being started as root on a few of our machines. We should modify the 'buildbot' script so that it exits with a failure message if you try and run it as root.

Comment 1

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1240888_Makefile.patch

Attached you can find the patch where I updated MAKEFILE in order to check if the make command is run as root for all the actions

Comment 2

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1240888.output

Attached the output from the tests that I made on dev-master2

Comment 3

[Chris AtLee [:catlee]]

Looks good, but I think in this case the problem was that somebody ran 'buildbot start' directly, bypassing the Makefile.

Comment 4

[Vlad Ciobancai [:vladC] [:vciobancai]]

(In reply to Chris AtLee [:catlee] from comment #3)
> Looks good, but I think in this case the problem was that somebody ran
> 'buildbot start' directly, bypassing the Makefile.

:catlee do you want us to try to find a way to block when a user tries to start a buildbot by using root account and not using the Makefile?

Comment 5

[Chris AtLee [:catlee]]

yes, since that's the ultimate script that is being run, I think the safest thing is to have it prevent itself running as root.

Comment 6

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1240888_buildbot.patch

Attached you can find the patch for buildbot script.
The patch check if the script is started, restarted or reconfig under root account, if yes the script will exit.

Comment 7

[Vlad Ciobancai [:vladC] [:vciobancai]]

Attachment: bug1240888_buildbot - Copy.output

Attached you can find the output from the tests that I made on dev-master2

Comment 8

[Vlad Ciobancai [:vladC] [:vciobancai]]

:kmoir :catlle can I close this bug ?

Comment 9

[Chris AtLee [:catlee]]

This needs to be deployed to take effect.

Comment 10

[Vlad Ciobancai [:vladC] [:vciobancai]]

(In reply to Chris AtLee [:catlee] from comment #9)
> This needs to be deployed to take effect.

The patch has been pushed to default branch.

Comment 11

[Kim Moir [:kmoir] ET]

I don't know if this is worth updating all the masters with given that 1) we don't have a really good story for updating them all pulling the latest code in and hoping that it works 2) buildbot is on it's way out.  There are other changes too if you compare default and production-0.8.

Comment 12

[Justin Wood (:Callek)]

(In reply to Kim Moir [:kmoir] from comment #11)
> I don't know if this is worth updating all the masters with given that 1) we
> don't have a really good story for updating them all pulling the latest code
> in and hoping that it works 2) buildbot is on it's way out.  There are other
> changes too if you compare default and production-0.8.

Though its still a footgun, noteworthy is that jlund also accidentally started buildbot as root just yesterday on a misbehaving master... and though buildbot is on its way out there is still a long tail there.