Closed Bug 1240890 Opened 8 years ago Closed 8 years ago

Advanced address book search fails with ReferenceError: encodeABTermValue is not defined in ABSearchDialog.js

Categories

(Thunderbird :: Address Book, defect)

Product:
Thunderbird
Component:
Address Book
Version:
43 Branch
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(thunderbird44 wontfix, thunderbird45+ fixed, thunderbird46 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 46.0
Tracking Flags:
Tracking Status
thunderbird44 --- wontfix
thunderbird45 + fixed
thunderbird46 --- fixed

People

(Reporter: wsmwk, Assigned: aceman)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
1.82 KB, patch
mkmelin
: review+
philip.chee
: review+
wsmwk
: feedback+
jorgk-bmo
: approval-comm-aurora+
Details | Diff | Splinter Review 
Tested today's daily and 44 beta.  So I assume version 45 is affected.

address book search fails for at least display name and email address with
Error: ReferenceError: encodeABTermValue is not defined
Source File: chrome://messenger/content/ABSearchDialog.js
Line: 293 

Above error is with nightly build
Is that the search in the AB dialog? Or you mean Edit -> Search addresses?
sorry, yes. Edit -> Search addresses.

tested also in safe mode - two different machines
Summary: address book search fails with ReferenceError: encodeABTermValue is not defined in ABSearchDialog.js → Advanced address book search fails with ReferenceError: encodeABTermValue is not defined in ABSearchDialog.js
OK, I can see it, it is in Edit->Search->Search addresses.
I assume it was caused by bug 1100801 where I moved the function.
Assignee: nobody → acelists
Blocks: 1100801
Status: NEW → ASSIGNED
Keywords: regressionwindow-wanted
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → 43 Branch
Attached patch patch — — Splinter Review 
Include the needed file containing the function.
Attachment #8709639 - Flags: feedback?(vseerror)
Comment on attachment 8709639 [details] [diff] [review]
patch

I got the same error :(

I double checked that the modified, reziped omni.ja should have been used with the added line
 Components.utils.import("resource:///modules/ABQueryUtils.jsm");
But the error called out the same line#, which doesn't seem possible.
Attachment #8709639 - Flags: feedback?(vseerror) → feedback-
Have you cleared the XUL cache?

I have reproduced the problem locally and the patch fixed it and I got search results (found cards).
Comment on attachment 8709639 [details] [diff] [review]
patch

works
Attachment #8709639 - Flags: feedback- → feedback+
Comment on attachment 8709639 [details] [diff] [review]
patch

Thanks for noticing the problem and testing the fix.

This probably affects Seamonkey too.
Attachment #8709639 - Flags: review?(philip.chee)
Attachment #8709639 - Flags: review?(mkmelin+mozilla)
Attachment #8709639 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 8709639 [details] [diff] [review]
patch

rs=me
Attachment #8709639 - Flags: review?(philip.chee) → review+
Thanks.
https://hg.mozilla.org/comm-central/rev/3ab5b7e89c4b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
Comment on attachment 8709639 [details] [diff] [review]
patch

Needs to go into TB45.

[Approval Request Comment]
Regression caused by (bug #): bug 1100801 (TB43)
User impact if declined: Non working advanced AB search!
Testing completed (on c-c, etc.): nightly
Risk to taking this patch (and alternatives if risky): hopefully none
Attachment #8709639 - Flags: approval-comm-aurora?
Attachment #8709639 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: