Closed Bug 1240908 Opened 4 years ago Closed 4 years ago

Make the window reference in nsContentPermissionRequester weak

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

It seems like a bad idea to have a strong nsGlobalWindow reference in a random class that is supposed to be transient, but might end up getting leaked.
This didn't affect the geolocation leak, so I filed a separate bug.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ede1cf265db5
Attachment #8709641 - Flags: review?(bugs)
Attachment #8709641 - Flags: review?(bugs) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9576824c598f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.