Closed Bug 1240955 Opened 8 years ago Closed 6 years ago

It's not obvious how to r+ a patch

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: francois, Unassigned)

Details

I just wanted to give some feedback on the review experience in case that's useful.

Giving someone an r+ after reviewing a patch is kinda confusing:

1. click "Finish Review"
2. click "Ship It"
3. click "Ok" (is this even needed?)
4. realize there's a publish button at the bottom right of the page and click "Publish Review"
5. do all of this again for the other patch in the same patch series

(That might be why gcp prefers I submit Safe Browsing patches for review outside of MozReview.)

It would be nice to just be able to click the [r?] in the Status column and change it to a [r+] there.
Product: Developer Services → MozReview
MozReview is now obsolete. Please use Phabricator instead. Closing this bug.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.