Closed Bug 1240990 Opened 4 years ago Closed 4 years ago

Define all backends in one place

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch Define all backends in one place (obsolete) — Splinter Review
When adding a backend, we currently have to add them in three different
places so that they appear in the right places.

Instead, keep the list in a single place.
Attachment #8709780 - Flags: review?(gps)
... with the required test change.
Attachment #8709780 - Attachment is obsolete: true
Attachment #8709780 - Flags: review?(gps)
Attachment #8709784 - Flags: review?(gps)
Comment on attachment 8709784 [details] [diff] [review]
Define all backends in one place

Review of attachment 8709784 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. Thank you for adding suitability checks to the backends.
Attachment #8709784 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/f7a8480e3efa
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Mike Hommey (or someone involved in this patch), could you take a look at bug 1268251 ? It seems this issue was caused by your patch (or your patch exposed some another issue here).

Thanks.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.