Handle AudioData with 0 frames

RESOLVED FIXED in Firefox 46

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
https://hg.mozilla.org/mozilla-central/file/b67316254602a63bf4e568198a5c7d3288a9db27/dom/media/mediasink/DecodedAudioDataSink.cpp#l236

It is possible for an AudioData to have 0 frames. We should ignore it and continue to process the next element to avoid silence.
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
(Assignee)

Comment 2

2 years ago
Created attachment 8710897 [details]
MozReview Request: Bug 1241003 - ignore AudioData with 0 frames to avoid silence. r=kinetik.

Review commit: https://reviewboard.mozilla.org/r/31905/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31905/
Attachment #8710897 - Flags: review?(kinetik)
Comment on attachment 8710897 [details]
MozReview Request: Bug 1241003 - ignore AudioData with 0 frames to avoid silence. r=kinetik.

https://reviewboard.mozilla.org/r/31905/#review28629
Attachment #8710897 - Flags: review?(kinetik) → review+
(Assignee)

Comment 4

2 years ago
Thanks!

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/357a870647f2
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.