1241026 - checksetup.pl requires editing localconfig to remove apache group

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

Right now, if you want to checkout bugzilla and do some dev work, you can use generate a cpanfile with checksetup and use cpanm to install the deps. If you're on a machine that does not have apache, you're not likely to have an 'apache' group and checksetup will complain. Thus we should change the default webserver group to an empty value.

Comment 1

[Frédéric Buclin]

As the comment says in localconfig, setting it to "" is very unsecure. I don't think this is a good default value for production installations. Most installations use Apache (because Apache is still very common) and we shouldn't put them in an unsecure environment by default. I much prefer that the few devs who do not have Apache installed clear this setting.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1241026_1.patch

Comment 3

[Dylan Hardison [:dylan] (he/him)]

(In reply to Frédéric Buclin from comment #1)
> As the comment says in localconfig, setting it to "" is very unsecure. I
> don't think this is a good default value for production installations. Most
> installations use Apache (because Apache is still very common) and we
> shouldn't put them in an unsecure environment by default. I much prefer that
> the few devs who do not have Apache installed clear this setting.

With this change, it should not be empty on a non-windows machine -- and it should also never be the name of a non-existing group.

Comment 4

[David Lawrence [:dkl]]

Comment on attachment 8711371 [details] [diff] [review]
1241026_1.patch

Review of attachment 8711371 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: Bugzilla/Install/Localconfig.pm
@@ +38,5 @@
>  );
>  
> +sub _sensible_group {
> +    return '' if ON_WINDOWS;
> +    my @groups     = qw( apache www-data _www );

should this be a constant maybe?

Comment 5

[Dylan Hardison [:dylan] (he/him)]

(In reply to David Lawrence [:dkl] from comment #4)
> Comment on attachment 8711371 [details] [diff] [review]
> 1241026_1.patch
> 
> Review of attachment 8711371 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=dkl
> 
> ::: Bugzilla/Install/Localconfig.pm
> @@ +38,5 @@
> >  );
> >  
> > +sub _sensible_group {
> > +    return '' if ON_WINDOWS;
> > +    my @groups     = qw( apache www-data _www );
> 
> should this be a constant maybe?

I think that wouldn't make it any more useful -- the value is used only there.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/bugzilla/bugzilla.git
   a0f345b..a8512ce  master -> master