Closed Bug 1241061 Opened 4 years ago Closed 4 years ago

[firefox-ui-tests] Add workaround for using ZipFile as long as bug 1237706 is not fixed

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set

Tracking

(firefox45 fixed, firefox46 fixed, firefox47 fixed)

RESOLVED FIXED
Tracking Status
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

We have to get our package handling for firefox-ui-tests out to our CI system in production, but are blocked on bug 1237706. Given that I will not be able to get that bug fixed in the next days we should have a workaround in our tests, so that we enforce the fallback to ZipFile.
For the workaround I duplicated the download_and_unzip method and added the zipfile code from bug 1237706. So once the other bug is fixed we can remove this part.

Given that zipfile is a bit slower, I updated the firefox-ui-tests download_and_extract method to only extract the files we really need.

I did a testrun on my local Win7 64bit VM and everything is green:
https://treeherder.allizom.org/#/jobs?repo=mozilla-central&revision=2e50b83954e6&filter-tier=3&selectedJob=2751553

Here the line in the logs where ZipFile is used:
https://treeherder.allizom.org/logviewer.html#?job_id=2751553&repo=mozilla-central#L74
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #8710357 - Flags: review?(mjzffr)
Attachment #8710357 - Flags: review?(mjzffr) → review+
We want this for both 46 and 45.
https://hg.mozilla.org/mozilla-central/rev/c345486a8f51
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
All the tests today in Mozmill CI on Windows nodes are finally green. So this patch works perfectly. It would be great to get this into aurora too. So this is a test-only change and don't affect the product.
Whiteboard: [checkin-needed-aurora]
We need a follow-up here given bug 1237706 comment 39. We extract with the wrong permissions which causes none to be set at all. But only in case of extracting a Windows tests.zip file on Linux. I consider removing this extra permissions check code. Will have to dig deeper into it.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [checkin-needed-aurora]
Depends on: 1242592
Similar to my patch for mozfile we have to update our unzip code for setting the correct permissions. I'm not sure when bug 1239808 will be fixed so we can always assume that we get the Windows zip archive as reference, which will cause permission errors (see bug 1242592).

A small change is necessary to actually make it work. Patch upcoming in a bit.
Status: REOPENED → ASSIGNED
Attachment #8712804 - Flags: review?(mjzffr)
Attachment #8712804 - Flags: review?(mjzffr) → review+
https://hg.mozilla.org/mozilla-central/rev/abd9ed577c62
Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
To be able to run our firefox-ui-tests via test packaging for the upcoming 45.0esr we need both patches landed on aurora and beta. This is testing code only and does not affect any other tests. Given that our tests are not run in-tree you can land both patches with DONTBUILD. Thanks.
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-aurora/rev/bf913423cd0e
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.