1241113 - The URL bar UI is incorrect when 'Open Last Bookmark' in pb mode

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Catalin Suciu [:csuciu]]

Build:2.0(1)

1. Bookmark a web page
2. Switch to private browsing mode
3. Background the app
4. 'Open Last Bookmark' through 3D touch

Result: The bookmark opens in pb mode (the private tab icon is purple), but the URL bar renders the UI from normal browsing (white background with black text)

Comment 1

[Emily Toop (:fluffyemily)]

Attachment: Pull request

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8710022 [details] [review]
Pull request

Looks good. So when you are in private mode and then open the last bookmark from the quick action menu, we open it in normal mode. I think this is fine and what people expect.

There is an issue with the tab count not being updated correctly, but I think we have a separate bug for that?

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This is the tab count bug https://bugzilla.mozilla.org/show_bug.cgi?id=1241047

Comment 4

[Emily Toop (:fluffyemily)]

(In reply to Stefan Arentz [:st3fan] from comment #3)
> This is the tab count bug
> https://bugzilla.mozilla.org/show_bug.cgi?id=1241047

Yup, that's the one next on my list.