1241158 - 3D Touch Quick Action opening normal tab when expecting private tab

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Emily Toop (:fluffyemily)]

STR

close all tabs, kill firefox
go to the iphone home screen, 3D Touch to New Tab
select a tile to open a page in the new tab
go to the iphone home screen, 3D Touch to New Private Tab
select a tile to open a page in the new private tab
oberve that the tab you are creating is not private
switch to private tabs. observe that there is now one empty private tab.

Comment 1

[Emily Toop (:fluffyemily)]

This is because when opening via a quick action from cold the flag we set to identify the required quick action is not being properly cleared. Therefore when you open via another action, the first action is executed again. When the second action is to open a private tab, this happens, but because the first action (open a normal tab) happens twice, the normal tab is the one displayed.

Comment 2

[Emily Toop (:fluffyemily)]

Attachment: Pull request

st3fan: chose you cos you have a 3D Touch device for testing.

Comment 3

[Aaron Train [:aaronmt]]

Is this the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1241089 filed today?

Comment 4

[Aaron Train [:aaronmt]]

(In reply to Aaron Train [:aaronmt] from comment #3)
> Is this the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1241089
> filed today?

Meant bug https://bugzilla.mozilla.org/show_bug.cgi?id=1241113

Comment 5

[Emily Toop (:fluffyemily)]

(In reply to Aaron Train [:aaronmt] from comment #4)
> (In reply to Aaron Train [:aaronmt] from comment #3)
> > Is this the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1241089
> > filed today?
> 
> Meant bug https://bugzilla.mozilla.org/show_bug.cgi?id=1241113

No. This is a different bug. Will take a look at Meant bug https://bugzilla.mozilla.org/show_bug.cgi?id=1241113

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8710006 [details] [review]
Pull request

Can't STR anymore. LGTM!