1241192 - Form validate invalid date parameters in SuperSearch

Status: RESOLVED WORKSFORME

(Socorro :: Webapp, task)

Description

[Peter Bengtsson [:peterbe]]

Attachment: Screen Shot 2016-01-20 at 1.09.05 PM.png

If you search for `date:>=2016-01-31` and `date:<=2016-01-01` there's a logical mismatch. There are no crashes that are greater than Jan 31st AND less than Jan 1st. 

Also, (see attached screenshot), this could easily be avoided by disallowing the date to be >TODAY.

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

I don't think we should prevent the date from being greater than today. However, we indeed should raise a comprehensible error when the date parameters are illogic.

Comment 2

[Peter Bengtsson [:peterbe]]

(In reply to Adrian Gaudebert [:adrian] from comment #1)
> I don't think we should prevent the date from being greater than today.
> However, we indeed should raise a comprehensible error when the date
> parameters are illogic.

Isn't the date tied to which index we query on?

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

It's the opposite, the indices are tied to the dates. But there's a protection mechanism in place, that will swallow errors about missing indices, so it's fine to be able to query in the future. Worst case it will return no results. The problem here is that we hit a very specific case where we query on zero indices. We could either detect that there is no index and return an empty result, or raise an exception about the logical mismatch.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Seems like SuperSearch is doing this now. This URL:

https://crash-stats.mozilla.com/search/?product=Firefox&date=%3E%3D2019-02-08T23%3A39%3A00.000Z&date=%3C2019-02-04T23%3A39%3A00.000Z&_facets=signature&page=1&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform

Kicks up this error:

date:

 * Operator combination failed 2019-02-08 23:39:00+00:00 >= 2019-02-04 23:39:00+00:00

I think we're good here.