Closed Bug 1241209 Opened 4 years ago Closed 3 years ago

TEST-UNEXPECTED-FAIL | toolkit/components/sqlite/tests/xpcshell/test_sqlite_internal.js | xpcshell return code: 0 | - false == true

Categories

(Thunderbird :: General, defect)

Unspecified
macOS
defect
Not set

Tracking

(thunderbird49 wontfix, thunderbird50 fixed, thunderbird_esr4549+ fixed, thunderbird51 fixed, thunderbird52 fixed)

RESOLVED FIXED
Thunderbird 52.0
Tracking Status
thunderbird49 --- wontfix
thunderbird50 --- fixed
thunderbird_esr45 49+ fixed
thunderbird51 --- fixed
thunderbird52 --- fixed

People

(Reporter: Fallen, Assigned: aleth)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

14:07:50  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/sqlite/tests/xpcshell/test_sqlite_internal.js |  - false == true
14:07:50     INFO -  /builds/slave/test/build/tests/xpcshell/tests/toolkit/components/sqlite/tests/xpcshell/test_sqlite_internal.js:worker.onmessage:22
14:07:50     INFO -  /builds/slave/test/build/tests/xpcshell/head.js:_do_main:208
14:07:50     INFO -  /builds/slave/test/build/tests/xpcshell/head.js:_execute_test:541
14:07:50     INFO -  -e:null:1
14:07:50     INFO -  exiting test
14:07:50     INFO -  Unexpected exception Error: Error: do_check_eq failed undefined != function at chrome://test_sqlite_internal/content/worker_sqlite_shared.js:25
14:07:50     INFO -  worker.onerror@/builds/slave/test/build/tests/xpcshell/tests/toolkit/components/sqlite/tests/xpcshell/test_sqlite_internal.js:37:17
14:07:50     INFO -  _do_main@/builds/slave/test/build/tests/xpcshell/head.js:211:5
14:07:50     INFO -  _execute_test@/builds/slave/test/build/tests/xpcshell/head.js:541:5
14:07:50     INFO -  @-e:1:1
14:07:50     INFO -  exiting test
14:07:50     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "Error: do_check_eq failed undefined != function" {file: "chrome://test_sqlite_internal/content/worker_sqlite_shared.js" line: 25}]"
Similar to bug 1232067 in some ways. OS X Opt in automation only. Fails in worker_sqlite_internal.js the first time a function declared in sqlite_internal.js is accessed (in this case, Sqlite.open from test_open_close(), but I suspect any other symbol would do). declareFFI in osfile_shared_allthreads.jsm has logging, but that doesn't seem to work in a worker context.
This test is a permafailure on c-c OS X Opt automation. Unfortunately, unlike what seemed a similar issue in Bug 1232067, I've had no luck debugging it. Since we'd see other failures if there really was an issue with SQLite, I think it's safe to disable this test on OS X.
Attachment #8800279 - Flags: review?(dteller)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8800279 [details] [diff] [review]
Disable test_sqlite_internal.js for Thunderbird OS X

Review of attachment 8800279 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
We're not even using this code, so I guess we should kill it.
Attachment #8800279 - Flags: review?(dteller) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d26b211c3a2bb56e9254f4c1a97c253054c4cefa
Bug 1241209 - Disable test_sqlite_internal.js for Thunderbird OS X. r=Yoric
https://hg.mozilla.org/mozilla-central/rev/d26b211c3a2b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
Comment on attachment 8800279 [details] [diff] [review]
Disable test_sqlite_internal.js for Thunderbird OS X

Approval Request Comment
[User impact if declined]: spurious OS X Opt comm-* test permafail
[Risks and why]: none - only disables a failing test for Thunderbird
Attachment #8800279 - Flags: approval-mozilla-esr45?
Attachment #8800279 - Flags: approval-mozilla-beta?
Attachment #8800279 - Flags: approval-mozilla-aurora?
Comment on attachment 8800279 [details] [diff] [review]
Disable test_sqlite_internal.js for Thunderbird OS X

test-only changes don't need approval, especially in this case since it's a TB-only manifest change
Attachment #8800279 - Flags: approval-mozilla-esr45?
Attachment #8800279 - Flags: approval-mozilla-beta?
Attachment #8800279 - Flags: approval-mozilla-aurora?
Whiteboard: [checkin-needed-aurora][checkin-needed-beta][checkin-needed-esr45]
https://hg.mozilla.org/releases/mozilla-aurora/rev/99dffa5be575
Whiteboard: [checkin-needed-aurora][checkin-needed-beta][checkin-needed-esr45] → [checkin-needed-beta][checkin-needed-esr45]
https://hg.mozilla.org/releases/mozilla-esr45/rev/f7bcdc50b307
Flags: in-testsuite-
Whiteboard: [checkin-needed-beta][checkin-needed-esr45]
You need to log in before you can comment on or make changes to this bug.