Closed
Bug 1241249
Opened 9 years ago
Closed 9 years ago
Add an SPS pseudo entry for JS stack capturing
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file)
|
3.46 KB,
patch
|
shu
:
review+
|
Details | Diff | Splinter Review |
This commit adds SPS pseudo frame entries for
`js::SavedStacks::saveCurrentStack` with the `AutoSPSEntry` RAII class.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8710081 -
Flags: review?(shu)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8710081 [details] [diff] [review]
Add an SPS pseudo entry for JS stack capturing
Review of attachment 8710081 [details] [diff] [review]:
-----------------------------------------------------------------
Sure...? What's this used for?
Attachment #8710081 -
Flags: review?(shu) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Shu-yu Guo [:shu] from comment #3)
> Comment on attachment 8710081 [details] [diff] [review]
> Add an SPS pseudo entry for JS stack capturing
>
> Review of attachment 8710081 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Sure...? What's this used for?
Makes it visible in the devtools' performance tool where we don't have native symbolication.
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•