1241260 - Properly clean up current composite task during force composites

Status: RESOLVED INVALID

(Core :: Graphics: Layers, defect)

Description

[Mason Chang [Inactive] [:mchang]]

When CompositorVsyncScheduler::Composite is called, it clears the current composite task [1]. However, during force composition [2], due to bug 1239861, we don't properly cancel the current composite task. We only set the current composite task to null. Instead, we should properly cancel the task.

[1] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/CompositorParent.cpp#432
[2] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/CompositorParent.cpp#482

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Properly cancel current composite task on force composites

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8710088 [details] [diff] [review]
Properly cancel current composite task on force composites

Review of attachment 8710088 [details] [diff] [review]:
-----------------------------------------------------------------

Did you find this just by code inspection, or was there a manifestation of this bug somewhere?

Comment 3

[Mason Chang [Inactive] [:mchang]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> Comment on attachment 8710088 [details] [diff] [review]
> Properly cancel current composite task on force composites
> 
> Review of attachment 8710088 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Did you find this just by code inspection, or was there a manifestation of
> this bug somewhere?

I was thinking about the code a bit more and realized I forgot to do this.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

I hope this fixes the other regressions from bug 1239861!

Comment 5

[Mason Chang [Inactive] [:mchang]]

Not applicable anymore with the changed code in bug 1239861. Closing.