Closed Bug 1241272 Opened 4 years ago Closed 4 years ago
Allow error() in moz
.build files to be treated as non-fatal
58 bytes, text/x-review-board-request
In bug 1230117 I added platform-specific logic to a moz.build file, and glandium suggested I add an error() to the else case to ensure that we'd fail sensibly on unsupported platforms. Unfortunately this makes test_filesystem_traversal_no_config fail, since it has no config and falls through the conditionals.
Calling error() in moz.build files to indicate unsupported configurations is useful, but readers using EmptyConfig will trigger them currently. This patch allows a Config to have an `error_is_fatal` attribute, which will make error emit a warning instead. Review commit: https://reviewboard.mozilla.org/r/31647/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/31647/
Attachment #8710102 - Flags: review?(gps)
Comment on attachment 8710102 [details] MozReview Request: bug 1241272 - Allow error() in moz.build files to be treated as non-fatal. r?gps https://reviewboard.mozilla.org/r/31647/#review28385
Attachment #8710102 - Flags: review?(gps) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/82e2e9c6de4e93c8017e5fe847b4cda9d29e0bce bug 1241272 - Allow error() in moz.build files to be treated as non-fatal. r=gps
You need to log in before you can comment on or make changes to this bug.