Closed Bug 1241284 Opened 5 years ago Closed 5 years ago

mozscreenshots: Don't do any work in TestRunner.init since it the extensions is installed in non-screenshot suites

Categories

(Testing :: mozscreenshots, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
Tracking Status
firefox46 --- fixed

People

(Reporter: MattN, Assigned: MattN)

References

Details

Attachments

(1 file)

The extension is installed in all mochitest suites so we shouldn't do work that's not needed in those suites.
The extension is installed in all mochitest suites so we shouldn't do work that's not needed in those suites.

Review commit: https://reviewboard.mozilla.org/r/31663/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31663/
Attachment #8710126 - Flags: review?(bgrinstead)
Comment on attachment 8710126 [details]
MozReview Request: Bug 1241284: mozscreenshots: Move TestRunner.init to `start` to avoid unnecessary work in other suites. r=bgrins

https://reviewboard.mozilla.org/r/31663/#review28409

Fixes the issue for me
Attachment #8710126 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/9300568c634b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Not clear.
Developer specific testing

Component: 
Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
Component: General → mozscreenshots
Product: Firefox → Testing
Target Milestone: Firefox 46 → ---
You need to log in before you can comment on or make changes to this bug.