Closed Bug 1241294 Opened 4 years ago Closed 4 years ago

Update E10S_AUTOSTART_STATUS telemetry probe (and rename it to E10S_STATUS)


(Firefox :: General, defect)

44 Branch
Not set



Firefox 46
Tracking Status
e10s m8+ ---
firefox45 + fixed
firefox46 --- fixed


(Reporter: Felipe, Assigned: Felipe)




(2 files)

In order to have a proper bug number to add to the histogram info, I'm splitting this up from bug 1234673.

We are adding some more criteria on disabling e10s (add-ons and certain locales), and the current telemetry probe has run out of buckets. We can't just increase the number of buckets so we need to create a new one.

I'll leave some spare buckets to avoid this in the future.

I'm also adding this as an "opt-out" for release because I think this is probably valuable information to get when e10s is released.

[Tracking Requested - why for this release]:
Necessary for the e10s beta45 experiment
Summary: Update E10S_AUTOSTART_TELEMETRY probe (and rename it) → Update E10S_AUTOSTART_STATUS telemetry probe (and rename it to E10S_STATUS)
Attached patch update histogramSplinter Review
Attachment #8710145 - Flags: review?(vladan.bugzilla)
Comment on attachment 8710145 [details] [diff] [review]
update histogram

Review of attachment 8710145 [details] [diff] [review]:

::: toolkit/components/telemetry/Histograms.json
@@ +8307,5 @@
> +    "alert_emails": [""],
> +    "expires_in_version": "never",
> +    "kind": "enumerated",
> +    "n_values": 12,
> +    "releaseChannelCollection": "opt-out",

good call on making this opt-out
Attachment #8710145 - Flags: review?(vladan.bugzilla) → review+
Comment on attachment 8710145 [details] [diff] [review]
update histogram

Approval Request Comment
[Feature/regressing bug #]: the e10s switching code that we plan to test on 45 has two new conditions to disable e10s (for some locales, bug 1234673, and users with add-ons, bug 1234675). They set values on this telemetry probe that needs to be updated to receive this new value.
[User impact if declined]: We won't be able to tell the % of users who are getting e10s disabled for these new reasons
[Describe test coverage new/current, TreeHerder]: landed on inbound
[Risks and why]: small, just a telemetry probe name change and increase in the number of options it accepts.
[String/UUID change made/needed]: the name of the probe is changed but that is not a localization string
Attachment #8710145 - Flags: approval-mozilla-aurora?
patch rebased for aurora. Approval request on comment 4.

It would be nice to get this in today, since bug 1234673 was approved and uplifted today, and that bug reports to this updated telemetry probe.
Attachment #8710568 - Flags: review+
Attachment #8710568 - Flags: approval-mozilla-aurora?
Comment on attachment 8710145 [details] [diff] [review]
update histogram

(clearing request from m-c patch)
Attachment #8710145 - Flags: approval-mozilla-aurora?
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Attachment #8710568 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [e10s-45-uplift]
Blocks: 1243882


STR: Not clear.
Developer specific testing

Name			Firefox
Version			46.0b9
Build ID		20160322075646
Update Channel          beta
User Agent		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS			Windows 7 SP1 x86_64

Expected Results: 
Developer specific testing

Actual Results: 
As expected
You need to log in before you can comment on or make changes to this bug.