1241305 - Write a test that verifies a favorite contact shows up in the favorite list and still in the regular list (In JS)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Kate Glazko]

Adding a JS Test to the Contacts details_test.js to check whether a favorited contact will show in the regular contacts list and the favorites list.

Comment 1

[Kate Glazko]

Attachment: Pull Request

Comment 2

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8710172 [details] [review]
Pull Request

That's a great start!

The test works fine on my set up. There are a couple of small nits, I left more details in the PR. 

Now that the first step is done, and we're sure there's no technical difficulties in writing the test[1], we can get the refactoring started. I'd suggest to handle this in the current bug so the PR fulfills the boy scout rule[2] :) 

Like we discussed by email, let's just split the views in order to make your test compliant with the patterns. 

[1] Yeah, sometimes it happens. For example, at some point, Marionette didn't implement a feature which made some parts of the DOM totally non-existent to it.
[2] http://www.informit.com/articles/article.aspx?p=1235624&seqNum=6

Comment 3

[Kate Glazko]

Added views, they live here, need to clean up before I PR and I made another branch and I need to figure out how to merge this into my previous branch and PR.

https://github.com/yglazko/gaia/commit/4479b74afae0fcaed81d32d7cf05bc0468566b4f2

Comment 4

[Johan Lorenzo [:jlorenzo]]

We're on the right track. I left comments at [1].

One way to pick the last commit from a branch to another:
> git checkout ${BRANCH_DESTINATION}
> git cherry-pick ${BRANCH_ORIGIN}

If you want to pick commits older in the tree.
> git cherry-pick ${BRANCH_ORIGIN}~N    # N being the number of commits between the top of BRANCH_ORIGIN and your wanted commit.

[1] Link corrected: https://github.com/yglazko/gaia/commit/4479b74afae0fcaed81d32d7cf05bc0468566b4f

Comment 5

[Kate Glazko]

Thank you Johan, I fixed a lot of the above! I migrated all of your comments to my PR, and deleted them as I fixed things. Right now, I have getting rid of the subject dependency and formatting left. For convenience, I rebased and squashed into one commit and the latest version lives here.

https://github.com/mozilla-b2g/gaia/pull/33928

Comment 6

[Kate Glazko]

(Which is the original pull request :) )

Comment 7

[Kate Glazko]

Fixed subject dependencies :D

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8710172 [details] [review]
Pull Request

We're getting closer! The main issue is that makeFavorited() doesn't wait on the header to be updated. The fix should be pretty straightforward. There are also some small nits here and there. I left more details on Github.

Once that is fixed, we'll be good to go, from my point of view.

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8710172 [details] [review]
Pull Request

LGTM, please address Johan's comments before merging.

Comment 10

[Kate Glazko]

https://github.com/mozilla-b2g/gaia/commit/6e9c78fa60392ee37401d59093c68e6737f06663