1241398 - Misc mach build-backend improvements

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Don't purge install manifests from the recursive make backend. r?gps

The code doing this was added before we had install manifests, back when
they were purge manifests, and before we tracked all files created by
the backend. Nowadays, if an install manifest is removed, it will be
removed in BuildBackend.consume.

In fact, purging the install manifests in the backend itself breaks the
deleted files count displayed after reticunating splines.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Remove the FilePurger class. r?gps

Its only last use was removed.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Show the diff for created and deleted files in `mach build-backend --diff`. r?gps

Comment 4

[Mike Hommey [:glandium]]

Attachment: Allow to pass the --verbose flag down to config.status from `mach build-backend`. r?gps

Comment 5

[Mike Hommey [:glandium]]

Attachment: Add a dry-run mode to `mach build-backend`. r?gps

When doing build system changes affecting backend-generated files, I
often use `mach build-backend --diff`. But most of the time I end up
wanting to look at the full diff again when doing further changes, which
leads me to stash my changes away, run `mach build-backend` to get the
initial state again, unstash and rerun `mach build-backend --diff`.

This has been a time drain for long enough :)

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8710291 [details] [diff] [review]
Add a dry-run mode to `mach build-backend`. r?gps

Review of attachment 8710291 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3fac4d023eaf
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c23d572349e
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff9243624046
https://hg.mozilla.org/integration/mozilla-inbound/rev/61577ee97921
https://hg.mozilla.org/integration/mozilla-inbound/rev/012e4a864921

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3fac4d023eaf
https://hg.mozilla.org/mozilla-central/rev/2c23d572349e
https://hg.mozilla.org/mozilla-central/rev/ff9243624046
https://hg.mozilla.org/mozilla-central/rev/61577ee97921
https://hg.mozilla.org/mozilla-central/rev/012e4a864921