Misc mach build-backend improvements

RESOLVED FIXED in Firefox 46

Status

RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla46

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(5 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8710287 [details] [diff] [review]
Don't purge install manifests from the recursive make backend. r?gps

The code doing this was added before we had install manifests, back when
they were purge manifests, and before we tracked all files created by
the backend. Nowadays, if an install manifest is removed, it will be
removed in BuildBackend.consume.

In fact, purging the install manifests in the backend itself breaks the
deleted files count displayed after reticunating splines.
(Assignee)

Comment 2

3 years ago
Created attachment 8710288 [details] [diff] [review]
Remove the FilePurger class. r?gps

Its only last use was removed.
(Assignee)

Comment 3

3 years ago
Created attachment 8710289 [details] [diff] [review]
Show the diff for created and deleted files in `mach build-backend --diff`. r?gps
(Assignee)

Comment 4

3 years ago
Created attachment 8710290 [details] [diff] [review]
Allow to pass the --verbose flag down to config.status from `mach build-backend`. r?gps
(Assignee)

Comment 5

3 years ago
Created attachment 8710291 [details] [diff] [review]
Add a dry-run mode to `mach build-backend`. r?gps

When doing build system changes affecting backend-generated files, I
often use `mach build-backend --diff`. But most of the time I end up
wanting to look at the full diff again when doing further changes, which
leads me to stash my changes away, run `mach build-backend` to get the
initial state again, unstash and rerun `mach build-backend --diff`.

This has been a time drain for long enough :)
(Assignee)

Updated

3 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Updated

3 years ago
Attachment #8710287 - Flags: review?(gps)
(Assignee)

Updated

3 years ago
Attachment #8710288 - Flags: review?(gps)
(Assignee)

Updated

3 years ago
Attachment #8710289 - Flags: review?(gps)
(Assignee)

Updated

3 years ago
Attachment #8710290 - Flags: review?(gps)
(Assignee)

Updated

3 years ago
Attachment #8710291 - Flags: review?(gps)
Attachment #8710287 - Flags: review?(gps) → review+
Attachment #8710288 - Flags: review?(gps) → review+
Attachment #8710289 - Flags: review?(gps) → review+
Attachment #8710290 - Flags: review?(gps) → review+
Comment on attachment 8710291 [details] [diff] [review]
Add a dry-run mode to `mach build-backend`. r?gps

Review of attachment 8710291 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice.
Attachment #8710291 - Flags: review?(gps) → review+

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.