Closed Bug 1241398 Opened 4 years ago Closed 4 years ago

Misc mach build-backend improvements

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(5 files)

No description provided.
The code doing this was added before we had install manifests, back when
they were purge manifests, and before we tracked all files created by
the backend. Nowadays, if an install manifest is removed, it will be
removed in BuildBackend.consume.

In fact, purging the install manifests in the backend itself breaks the
deleted files count displayed after reticunating splines.
Its only last use was removed.
When doing build system changes affecting backend-generated files, I
often use `mach build-backend --diff`. But most of the time I end up
wanting to look at the full diff again when doing further changes, which
leads me to stash my changes away, run `mach build-backend` to get the
initial state again, unstash and rerun `mach build-backend --diff`.

This has been a time drain for long enough :)
Assignee: nobody → mh+mozilla
Attachment #8710287 - Flags: review?(gps)
Attachment #8710288 - Flags: review?(gps)
Attachment #8710289 - Flags: review?(gps)
Attachment #8710290 - Flags: review?(gps)
Attachment #8710291 - Flags: review?(gps)
Attachment #8710287 - Flags: review?(gps) → review+
Attachment #8710288 - Flags: review?(gps) → review+
Attachment #8710289 - Flags: review?(gps) → review+
Attachment #8710290 - Flags: review?(gps) → review+
Comment on attachment 8710291 [details] [diff] [review]
Add a dry-run mode to `mach build-backend`. r?gps

Review of attachment 8710291 [details] [diff] [review]:
-----------------------------------------------------------------

Very nice.
Attachment #8710291 - Flags: review?(gps) → review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.