12414 - New profiles have dup directory structure

Status: VERIFIED INVALID

(Core Graveyard :: Profile: BackEnd, enhancement, P3)

Description

[Phil Peterson]

To get around the problem where profiles go in dist by default, I created a
profile in a non-default location. I asked it to create "phil2" in
"y:\mozilla\users50\phil2" and it created "y:\mozilla\users50\phil2\phil2". Not
what I expected.

Comment 1

[selmer (gone)]

Actually, it's asking for the directory to put the profile directory in and then
it's creating the profile's directory in the one you named.  Thus, if you
include the profile name in your input, it'll get duplicated.

I also think this is the wrong behavior, so I'm going to leave this open as an
enhancement request unless I see it's a dup when I check.

For regular customers, profiles won't be going in something called 'dist' and
they have few compelling reasons to change it manually.

Comment 2

[leger]

Moving all Profile Manager bugs to new Profile Manager Backend component.
Profile Manager component to be deleted.

Comment 3

[selmer (gone)]

Bhuvan, is this a dup of something?  I thought this was fixed at some point, but
I never got back to this bug to update it.  Thanks.

Comment 4

[racham]

Given the way our UI is right now, we select a folder from the file dialog. 
Frontend passes that path to the backend. On the backend, we always append the 
profile name to the folder name passed from javascript. This step has taken to 
avoid the dangerous bug we ran into in the past, bug 20198. Suppose if the user 
has selected C:\as his profile folder, if we don't append the profile name to it 
, when he/she chooses to delete that profile we are talking about deleting C:\.

So, adding the profile name on the backend (always) caused this bug. The 
behavior we have now is more safer though in the cases where phil reported, we 
might end up with a duplicate directory structure. However, I welcome your input 
on this if we have to do it any different. 

Comment 5

[racham]

Given the current UI we have to choose the profile folder, I think what we have  
is good enough. Marking this invalid.

Comment 6

[Grace Bush]

verified

Comment 7

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/2ac3175cdd3d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12414 - Support sharing images through ShareDownloadFeature