1241405 - WARNING: Can't add a range if the end is older that the start.: file dom/html/TimeRanges.cpp, line 87

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Attachment: test_TimeRanges_warning.html

Got the warnings in running test_TimeRanges_warning.html.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

call flow:
1. mCurrentPlayRangeStart is assigned to currentTime() (which is 5 in the test case) in HTMLMediaElement::SeekCompleted().
2. assign a new URI to the media element.
3. call play() on the media element.
4. we have mCurrentPlayRangeStart==5 and now==0 in HTMLMediaElement::Played()
5. we hit the warning when calling |ranges->Add(mCurrentPlayRangeStart, now)|.

fix:
reset mCurrentPlayRangeStart to -1.0 when loading a new URI.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1241405 - reset mCurrentPlayRangeStart in AbortExistingLoads(). r=jya.

Review commit: https://reviewboard.mozilla.org/r/31909/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31909/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8710900 [details]
MozReview Request: Bug 1241405 - reset mCurrentPlayRangeStart in AbortExistingLoads(). r=jya.

https://reviewboard.mozilla.org/r/31909/#review28637

FWIW, I used to see exactly that error message in the MDSM. Following the change from TimeRanges to TimeIntervals (which has a strong assert should end < start) I added this change https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaDecoderStateMachine.cpp#1887 in the MDSM

Not sure if that's related.
but there, often Duration().ToMicroseconds() was < endOfDecodedData causing to assert

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review. I can't find which revision has the assertion.

Comment 5

[Jean-Yves Avenard [:jya]]

(In reply to JW Wang [:jwwang] from comment #4)
> Thanks for the review. I can't find which revision has the assertion.

the assertion is in the TimeIntervals constructor
https://dxr.mozilla.org/mozilla-central/source/dom/media/Intervals.h#56

change occurred there:
https://hg.mozilla.org/mozilla-central/diff/24a7f0fda98b/dom/media/MediaDecoderStateMachine.cpp#l1.86

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f921828136da

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f921828136da