Closed Bug 1241416 Opened 4 years ago Closed 4 years ago

Create a tier for things happening before export

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

No description provided.
While it would be possible to move those things in the export tier, it
is still interesting to have reporting for them separately, especially
considering I expect things to gradually move from the other tiers to
this new one.

While not entirely obvious, the recurse_pre-export target doesn't imply
actual recursion as long as the RecursiveMake backend doesn't emit
traversal information for it, so nothing will actually happen on this
target, but the interesting part is that it runs, per the generic
config/recurse.mk rules for tiers, between BUILDSTATUS TIER_START and
BUILDSTATUS TIER_FINISH, so that all its dependencies are accounted
as being part of the pre-export tier.
Attachment #8710302 - Flags: review?(gps)
(In reply to Mike Hommey [:glandium] from comment #1)
> Created attachment 8710302 [details] [diff] [review]
> Create a tier for things happening before export
> 
> While it would be possible to move those things in the export tier, it
> is still interesting to have reporting for them separately, especially
> considering I expect things to gradually move from the other tiers to
> this new one.

I should probably clarify what I mean here: my work on bug 1239217 will make things move from any tier to this new tier mechanically when their support is added to the FasterMake backend.
Comment on attachment 8710302 [details] [diff] [review]
Create a tier for things happening before export

Review of attachment 8710302 [details] [diff] [review]:
-----------------------------------------------------------------

I could bikeshed the tier name. But I got nothing better.
Attachment #8710302 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/abd3c51d6eb1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.