Implement GB18030-2005

RESOLVED FIXED in Firefox 46

Status

()

Core
Internationalization
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

(Blocks: 1 bug)

unspecified
mozilla46
Points:
---

Firefox Tracking Flags

(firefox46 fixed)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
To align with a recent change to Encoding Standard.
(Assignee)

Comment 1

2 years ago
Created attachment 8710414 [details] [diff] [review]
patch

According to bug 79275, GB18030 mapping tables are generated from "GB18030" file on unicode.org. But I could not regenerate mapping tables because apparently unicode.org does not provide this file anymore. So I hard-coded the mapping change.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8710414 - Flags: review?(smontagu)
Comment on attachment 8710414 [details] [diff] [review]
patch

Review of attachment 8710414 [details] [diff] [review]:
-----------------------------------------------------------------

The hardcoding is ugly, but it's probably the best alternative -- trying to reconstruct GB18030 from a mapping file from some other source would be riskier.
Attachment #8710414 - Flags: review?(smontagu) → review+
(Assignee)

Comment 3

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d666d6a2c7e
(Assignee)

Comment 4

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6866790f5329
(Assignee)

Comment 5

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2004ed184677f73c745b1fd423f66921c5b61e4
Bug 1241432 - Implement GB18030-2005. r=smontagu

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d2004ed18467
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.