1241436 - User shouldn't be able to enter email address if the "email me when more info is available" option is unchecked in the tab crash reporter

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Paul Silaghi, QA [:pauly]]

46.0a1 (2016-01-20) Win 7
STR:
1. Install http://people.mozilla.org/~tmielczarek/crashme/
2. Go to Customize and move the "crash content process" button to the menu panel
3. Crash the current tab
4. Expand the crash reporter
5. Without checking the "email me when more info is available" option, try to write something in the 'email address' field

Actual results:
able to enter email address even if "email me when more info is available" option is unchecked

Expected results:
User shouldn't be able to enter email address if the "email me when more info is available" option is unchecked

Comment 1

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160205004003
 
This issue is also reproducible on the latest Aurora 46.0a2 when e10s is enabled.

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Bug 1241436 - Update the "email me" checkbox in accordance with the email input field in the tab crash reporter.

Review commit: https://reviewboard.mozilla.org/r/67138/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67138/

Comment 3

[:Felipe Gomes (needinfo for replies!)]

I honestly think that the behavior should be: if the user starts typing an email address there, we should automatically check the checkbox (1).

When you think about it, the checkbox is really pointless: either the user leaves a blank e-mail field and doesn't want to be contacted, or enters an e-mail and do. (2)

What about changing the patch to do (1), and we file a new bug to discuss more about removing the checkbox and changing the placeholder text to make (2) clear?

Comment 4

[Cervantes Yu [:cyu] [:cervantes]]

Comment on attachment 8774691 [details]
Bug 1241436 - Update the "email me" checkbox in accordance with the email input field in the tab crash reporter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67138/diff/1-2/

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8774691 [details]
Bug 1241436 - Update the "email me" checkbox in accordance with the email input field in the tab crash reporter.

https://reviewboard.mozilla.org/r/67138/#review64806

Comment 6

[Cervantes Yu [:cyu] [:cervantes]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d42dc451447

Comment 7

[Cervantes Yu [:cyu] [:cervantes]]

Comment on attachment 8774691 [details]
Bug 1241436 - Update the "email me" checkbox in accordance with the email input field in the tab crash reporter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/67138/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ce7bd81fd06
Update the "email me" checkbox in accordance with the email input field in the tab crash reporter. r=Felipe

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ce7bd81fd06

Comment 10

[Sayed [:LiquidO2]]

I have reproduced this with Nightly 46.0a1 (2016-01-21) on Elementary OS 64bit. 

This fix is now verified on latest Nightly 51.0a1

Build ID 	20160806030806
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160803]