1241476 - Update in-tree libcubeb

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Update our in-tree libcubeb to bring in the full-duplex changes and some device-enumeration updates.

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01c279ae2fb4

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this (and everything else from this push) out for causing various crashes on WinXP. They all seem to mention "winmm_stream_init" or "cubeb_winmm.c".

https://treeherder.mozilla.org/logviewer.html#?job_id=20232505&repo=mozilla-inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/739da31ca2e2

Comment 3

[Matthew Gregan [:kinetik]]

A write to 0x0 is usually libcubeb's XASSERT firing.  There should be a message printed to stderr, but I can't find it in the log.

Anyway, looking at the very few changes made to cubeb_winmm.c since the last landing, the problem is pretty obvious:

  XASSERT(input_stream_params && "not supported.");

should be:

  XASSERT(!input_stream_params && "not supported.");

...like it is in all of the other backends.

Pushed a fix upstream here: https://github.com/kinetiknz/cubeb/commit/2de1ab50e16763fd88ec1b5bae30422de598eed0

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4db43c72f53

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c4db43c72f53