Closed
Bug 1241595
Opened 8 years ago
Closed 8 years ago
Refactoring session for the json pushes interface
Categories
(Testing :: mozregression, defect)
Testing
mozregression
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: parkouss, Assigned: parkouss)
Details
Attachments
(1 file)
I don't like much the current json pushes interfaces, and in multiple places in the code we (myself :)) used words such as "raw_pushes", or used private methods because the interface of the JSonPushes class is not really good. I'd like to improve it. I think something really good would be to return instance of custome Push objects, that would cache the json data we get from the servers and provide simple interface on it.
|
Assignee | |
Comment 1•8 years ago
|
||
:wlach, I know this is not easy to review. :( I ask you for a quick review, just in case you catch something obvious. From what I tested, it looks good. Thanks!
Attachment #8710622 -
Flags: review?(wlachance)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8710622 [details] [review] refactoring json-pushes This looks fine to me.
Attachment #8710622 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Landed in: https://github.com/parkouss/mozregression/commit/0db3026983f37e019c5ba488163b9ff4c237322d https://github.com/parkouss/mozregression/commit/5057c5144837fd958c60d2ed5825058cd1e13ec8 https://github.com/parkouss/mozregression/commit/4dacc239d35663382a694f880cdce218453c08fc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•