Status

()

3 years ago
3 years ago

People

(Reporter: antlam, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8710709 [details]
prev_bookmarks_RLfolder2b.png

Showing offline items when the user is "offline" should just work. Then there should be UX to "show all".

Just like the work we've been doing to show cached versions of web pages. We should show the same banner along the bottom (in blue) to reinforce the offline nature of Fennec.
(Reporter)

Comment 1

3 years ago
Created attachment 8710713 [details]
prev_bookmarks_RLfolder2b.png

48dp tall
Link blue
Roboto regular, 14sp, white, 15dp padding from left
action button : Roboto medium 14sp, 15dp padding from right
Attachment #8710709 - Attachment is obsolete: true

Comment 2

3 years ago
Given the way bookmark and history items are saved in the DB, there's no way for us to currently do this.

If we add logic to make sure we add reader view content to our offline reader view cache when those pages are bookmarked, we could make an assumption that all reader view bookmarks are offline. However, I don't know that we want to go down that road, since at some point we'll want to evict entries from the cache if it grows really large.

I think we need to think more specifically about the UX flow around saving and retrieving reader view content, rather than thinking more generally about "offline".

For example, maybe we should just have a smart bookmark folder that automatically includes all of your saved about:reader pages. And we could guarantee that the N most recently saved ones will have content available offline.
(Reporter)

Comment 3

3 years ago
(In reply to :Margaret Leibovic from comment #2)
> I think we need to think more specifically about the UX flow around saving
> and retrieving reader view content, rather than thinking more generally
> about "offline".

I want to keep this bug only about indicating to the user that Firefox is offline and therefore, showing offline stuff - when it's possible. :) 

Wasn't bug 1234331 filed to track bookmarking reader view content? That should cover the UX for saving and retrieving reader view content.

> For example, maybe we should just have a smart bookmark folder that
> automatically includes all of your saved about:reader pages. And we could
> guarantee that the N most recently saved ones will have content available
> offline.

I think we've discussed this as a V2 before. It's a natural progression for where we want to head next and I think it makes sense. But I worry that we're changing a lot of our users existing mental models all at once. The expectations for Bookmarks to be synced, and now Offline as well, is a simple enough model. 

Pages that are in Reader View can be bookmarked as well, just like any other page. But if we start doing this automatically, making some available, some not, it will probably get a bit messy.
You need to log in before you can comment on or make changes to this bug.