Closed Bug 1241703 Opened 4 years ago Closed 4 years ago

browser_contextmenu.js is going to permafail when Gecko 46 is uplifted to Aurora

Categories

(Firefox :: Search, defect, blocker)

defect
Not set
blocker

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox46 + fixed
firefox47 --- fixed

People

(Reporter: RyanVM, Assigned: enndeakin)

Details

Looks like bug 1235372 was the only thing to touch this test recently, so starting with that suspicion. Did the rewrite make use of a nightly-only feature by chance?

https://treeherder.mozilla.org/logviewer.html#?job_id=15759419&repo=try

Screenshot:
http://mozilla-releng-blobs.s3.amazonaws.com/blobs/try/sha512/e6f010972100c63aa250e3c84d0074b699fbaa6d54ee8921a38624d0a695bb822a7ea2393186fb45dd8109cce31f7b5a057b9baaa0891033eb80605bd362fb18
Flags: needinfo?(enndeakin)
15:12:54 INFO - JavaScript error: chrome://mochitests/content/browser/browser/components/search/test/browser_contextmenu.js, line 29: ReferenceError: ok is not defined
Looks like dom.select_events.enabled is only enabled on nightly. This is bug 1231923.

I can make this test set the preference beforehand, or just rework it.
Flags: needinfo?(enndeakin)
[Tracking Requested - why for this release]: massive permaorange on the 2016-01-25 uplift.

Wow, Ryan filed on the 46->beta bustage before I even got to the 46->aurora bustage.

We've actually only got until Monday morning, not the six weeks plus two days before it hits beta, so could you set the pref, um, today?
Severity: major → blocker
Flags: needinfo?(enndeakin)
Summary: browser_contextmenu.js is going to permafail when Gecko 46 is uplifted to Beta → browser_contextmenu.js is going to permafail when Gecko 46 is uplifted to Aurora
https://hg.mozilla.org/mozilla-central/rev/ae764f907bb0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 46
Assignee: nobody → enndeakin
Target Milestone: Firefox 46 → Firefox 47
Flags: needinfo?(enndeakin)
Resolved already, tracking belatedly in case it reopens.
You need to log in before you can comment on or make changes to this bug.