1241747 - [porting][nexusplayer] device-google-atv porting

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Farmer Tseng[:fatseng](inactive)]

Modify atv_base.mk to solve build break and add b2g necessary

Comment 1

[Farmer Tseng[:fatseng](inactive)]

Attachment: device-google-atv PR

1. Remove unused module libfilterpack_imageproc.
   It causes build break.
2. Do not store the Android ringtones in the system image(Bug 825142)

We also removed above two in mozilla-b2g/platform_build.

3. Inherit external/moztt/fonts.mk and gonk-misc/b2g.mk

Comment 2

[:gerard-majax]

Comment on attachment 8710830 [details] [review]
device-google-atv PR

I'm not sure why you need b2g.mk and fonts.mk

Comment 3

[Farmer Tseng[:fatseng](inactive)]

(In reply to Alexandre LISSY :gerard-majax from comment #2)
> Comment on attachment 8710830 [details] [review]
> device-google-atv PR
> 
> I'm not sure why you need b2g.mk and fonts.mk

They have been added into build/target/product/generic_no_telephony.mk
I hit build break without b2g.mk.
Here is error message.
"build/core/base_rules.mk:158: *** system/core/rootdir: MODULE.TARGET.ETC.init.rc already defined by gonk-misc.  Stop."

Without fonts.mk, nexusplayer becomes black screen.
It hit system crash while booting.

Comment 4

[:gerard-majax]

(In reply to Farmer Tseng[:fatseng] from comment #3)
> (In reply to Alexandre LISSY :gerard-majax from comment #2)
> > Comment on attachment 8710830 [details] [review]
> > device-google-atv PR
> > 
> > I'm not sure why you need b2g.mk and fonts.mk
> 
> They have been added into build/target/product/generic_no_telephony.mk
> I hit build break without b2g.mk.
> Here is error message.
> "build/core/base_rules.mk:158: *** system/core/rootdir:
> MODULE.TARGET.ETC.init.rc already defined by gonk-misc.  Stop."

I guess you need to read Android.mk there ;)

Hint: ifneq ($(TARGET_PROVIDES_B2G_INIT_RC),true)

> 
> Without fonts.mk, nexusplayer becomes black screen.
> It hit system crash while booting.

Ok, so you don't need fonts.mk in that file now?

Comment 5

[Farmer Tseng[:fatseng](inactive)]

(In reply to Alexandre LISSY :gerard-majax from comment #4)
> (In reply to Farmer Tseng[:fatseng] from comment #3)
> > (In reply to Alexandre LISSY :gerard-majax from comment #2)
> > > Comment on attachment 8710830 [details] [review]
> > > device-google-atv PR
> > > 
> > > I'm not sure why you need b2g.mk and fonts.mk
> > 
> > They have been added into build/target/product/generic_no_telephony.mk
> > I hit build break without b2g.mk.
> > Here is error message.
> > "build/core/base_rules.mk:158: *** system/core/rootdir:
> > MODULE.TARGET.ETC.init.rc already defined by gonk-misc.  Stop."
> 
> I guess you need to read Android.mk there ;)
> 
> Hint: ifneq ($(TARGET_PROVIDES_B2G_INIT_RC),true)
> 
> > 
> > Without fonts.mk, nexusplayer becomes black screen.
> > It hit system crash while booting.
> 
> Ok, so you don't need fonts.mk in that file now?

I mean I need it.

Comment 6

[Farmer Tseng[:fatseng](inactive)]

(In reply to Alexandre LISSY :gerard-majax from comment #4)
> (In reply to Farmer Tseng[:fatseng] from comment #3)
> > (In reply to Alexandre LISSY :gerard-majax from comment #2)
> > > Comment on attachment 8710830 [details] [review]
> > > device-google-atv PR
> > > 
> > > I'm not sure why you need b2g.mk and fonts.mk
> > 
> > They have been added into build/target/product/generic_no_telephony.mk
> > I hit build break without b2g.mk.
> > Here is error message.
> > "build/core/base_rules.mk:158: *** system/core/rootdir:
> > MODULE.TARGET.ETC.init.rc already defined by gonk-misc.  Stop."
> 
> I guess you need to read Android.mk there ;)
> 
> Hint: ifneq ($(TARGET_PROVIDES_B2G_INIT_RC),true)
> 
Per checked, I found init.rc already defined in gonk-misc/Android.mk.
Therefore, I need b2g.mk to set TARGET_PROVIDES_B2G_INIT_RC as true.
Besides, I also need b2g.mk to add other stuff, like sepolicy.
> > 
> > Without fonts.mk, nexusplayer becomes black screen.
> > It hit system crash while booting.
> 
> Ok, so you don't need fonts.mk in that file now?
I mean system would hit crash if I don't include font.mk
gecko/gfx/thebes/gfxFT2FontList.cpp can't ready fonts under /system/font/.
So, I need it.
Here is error log.
01-25 10:21:57.205 I/Gecko   (  171): [171] ###!!! ABORT: Could not read the system fonts directory: file ../../../gecko/gfx/thebes/gfxFT2FontList.cpp, line 1188
01-25 10:21:57.205 E/Gecko   (  171): mozalloc_abort: [171] ###!!! ABORT: Could not read the system fonts directory: file ../../../gecko/gfx/thebes/gfxFT2FontList.cpp, line 1188

Comment 7

[:gerard-majax]

(In reply to Farmer Tseng[:fatseng] from comment #6)
> (In reply to Alexandre LISSY :gerard-majax from comment #4)
> > Hint: ifneq ($(TARGET_PROVIDES_B2G_INIT_RC),true)
> > 
> Per checked, I found init.rc already defined in gonk-misc/Android.mk.
> Therefore, I need b2g.mk to set TARGET_PROVIDES_B2G_INIT_RC as true.
> Besides, I also need b2g.mk to add other stuff, like sepolicy.

I don't understand. Does your device already provides an init.rc suitable for B2G ? Or does it already does a copy of Android's init.rc that would mess with this definition?

You might just need to toggle that variable.

Comment 8

[Farmer Tseng[:fatseng](inactive)]

Attachment: device-asus-fugu PR

use system/core/rootdir/init.rc

Comment 9

[Farmer Tseng[:fatseng](inactive)]

Per checked, Using system/core/rootdir/init.rc is enough.
I don't meet build break and device could boot to TV home screen.
Please help review both patches.

Comment 10

[Farmer Tseng[:fatseng](inactive)]

https://github.com/mozilla-b2g/device-google-atv/commit/b8b9f0020ddb7510534d3d046b765ed3db11e13b
https://github.com/mozilla-b2g/device-asus-fugu/commit/aea2bbf0ef9f57882f3265e65ed0ef84d2e1a230