1241750 - (enable-details-summary-nightly-aurora) Enable <details> and <summary> on Nightly/Aurora

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I think once bug 591737 and bug 1225412 are landed, all the requirements in the spec should be implemented. We can flip the pref to enable <details> and <summary> on Nightly and Aurora to gain more testing.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

It seems to me that if a feature is complete, we could just make it enabled by default for all and let it ride the train, unless we find any serious issue whose fix cannot be done in time or is not upliftable.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

That says, we can enable it here, but keep the pref there so that we can turn it off any time if necessary.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Xidorn Quan [:xidorn] (UTC+8) from comment #1)
> It seems to me that if a feature is complete, we could just make it enabled
> by default for all and let it ride the train, unless we find any serious
> issue whose fix cannot be done in time or is not upliftable.

There are other dependencies of bug 1226455.


(Also, adding the other dependency explicitly mentioned in comment 0.)

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: MozReview Request: Bug 1241750 - Enable <details> and <summary> on Nightly and Aurora. r=bz

Review commit: https://reviewboard.mozilla.org/r/39657/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39657/

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8730082 [details]
MozReview Request: Bug 1241750 - Enable <details> and <summary> on Nightly and Aurora. r=bz

https://reviewboard.mozilla.org/r/39657/#review36701

r=me.  Sorry for the terrible lag.  :(

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://reviewboard.mozilla.org/r/39657/#review36701

Don't be sorry. Thank you for the review :)

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8730082 [details]
MozReview Request: Bug 1241750 - Enable <details> and <summary> on Nightly and Aurora. r=bz

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39657/diff/1-2/

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://reviewboard.mozilla.org/r/39657/#review36863

::: dom/tests/mochitest/general/test_interfaces.html:553
(Diff revision 2)
>  // IMPORTANT: Do not change this list without review from a DOM peer!
>      "HTMLDataElement",
>  // IMPORTANT: Do not change this list without review from a DOM peer!
>      "HTMLDataListElement",
>  // IMPORTANT: Do not change this list without review from a DOM peer!
> -    {name: "HTMLDetailsElement", disabled: true},
> +    {name: "HTMLDetailsElement", release: false},

Ouch. I forgot to change this in my previous patch ...

Comment 9

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8730082 [details]
MozReview Request: Bug 1241750 - Enable <details> and <summary> on Nightly and Aurora. r=bz

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39657/diff/2-3/

Comment 10

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Since bug 1225412 is landed, some svg tests in web-platform-test are pass with toggle events after I rebased. I mark them all pass in patch set 3.

Boris, I touch two test files, which might need a re-review. mozreview don't support change the r+ to r?, so I just NI you here. See https://reviewboard.mozilla.org/r/39657/diff/3#index_header

Latest try (all green):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=31914171d5f8

Comment 11

[Boris Zbarsky [:bzbarsky]]

r=me, but please file a bug on mozreview for not being able to change "r+" to "r?".

Comment 12

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

(In reply to Boris Zbarsky [:bz] from comment #11)
> r=me, but please file a bug on mozreview for not being able to change "r+"
> to "r?".

We'll have the fix in bug 1195661. I hope it land soon :)

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72641acb6467

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/72641acb6467