Closed Bug 1241750 (enable-details-summary-nightly-aurora) Opened 5 years ago Closed 4 years ago

Enable <details> and <summary> on Nightly/Aurora

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed)

Attachments

(1 file)

I think once bug 591737 and bug 1225412 are landed, all the requirements in the spec should be implemented. We can flip the pref to enable <details> and <summary> on Nightly and Aurora to gain more testing.
It seems to me that if a feature is complete, we could just make it enabled by default for all and let it ride the train, unless we find any serious issue whose fix cannot be done in time or is not upliftable.
That says, we can enable it here, but keep the pref there so that we can turn it off any time if necessary.
Depends on: 1246185
(In reply to Xidorn Quan [:xidorn] (UTC+8) from comment #1)
> It seems to me that if a feature is complete, we could just make it enabled
> by default for all and let it ride the train, unless we find any serious
> issue whose fix cannot be done in time or is not upliftable.

There are other dependencies of bug 1226455.


(Also, adding the other dependency explicitly mentioned in comment 0.)
Alias: enable-details-summary-nightly-aurora
Depends on: 1225412
Comment on attachment 8730082 [details]
MozReview Request: Bug 1241750 - Enable <details> and <summary> on Nightly and Aurora. r=bz

https://reviewboard.mozilla.org/r/39657/#review36701

r=me.  Sorry for the terrible lag.  :(
Attachment #8730082 - Flags: review?(bzbarsky) → review+
https://reviewboard.mozilla.org/r/39657/#review36701

Don't be sorry. Thank you for the review :)
Comment on attachment 8730082 [details]
MozReview Request: Bug 1241750 - Enable <details> and <summary> on Nightly and Aurora. r=bz

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39657/diff/1-2/
Attachment #8730082 - Attachment description: MozReview Request: Bug 1241750 - Enable <details> and <summary> on Nightly and Aurora. r?bz → MozReview Request: Bug 1241750 - Enable <details> and <summary> on Nightly and Aurora. r=bz
https://reviewboard.mozilla.org/r/39657/#review36863

::: dom/tests/mochitest/general/test_interfaces.html:553
(Diff revision 2)
>  // IMPORTANT: Do not change this list without review from a DOM peer!
>      "HTMLDataElement",
>  // IMPORTANT: Do not change this list without review from a DOM peer!
>      "HTMLDataListElement",
>  // IMPORTANT: Do not change this list without review from a DOM peer!
> -    {name: "HTMLDetailsElement", disabled: true},
> +    {name: "HTMLDetailsElement", release: false},

Ouch. I forgot to change this in my previous patch ...
Comment on attachment 8730082 [details]
MozReview Request: Bug 1241750 - Enable <details> and <summary> on Nightly and Aurora. r=bz

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/39657/diff/2-3/
Since bug 1225412 is landed, some svg tests in web-platform-test are pass with toggle events after I rebased. I mark them all pass in patch set 3.

Boris, I touch two test files, which might need a re-review. mozreview don't support change the r+ to r?, so I just NI you here. See https://reviewboard.mozilla.org/r/39657/diff/3#index_header

Latest try (all green):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=31914171d5f8
Flags: needinfo?(bzbarsky)
r=me, but please file a bug on mozreview for not being able to change "r+" to "r?".
Flags: needinfo?(bzbarsky)
(In reply to Boris Zbarsky [:bz] from comment #11)
> r=me, but please file a bug on mozreview for not being able to change "r+"
> to "r?".

We'll have the fix in bug 1195661. I hope it land soon :)
https://hg.mozilla.org/mozilla-central/rev/72641acb6467
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.