Closed
Bug 1241767
Opened 9 years ago
Closed 9 years ago
Patch from bug 1239605 will burn Windows builds on mozilla-aurora on 2016-01-25
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: philor, Assigned: lth)
References
Details
Attachments
(1 file)
|
1.36 KB,
patch
|
bbouvier
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/rev/56c5187a2c64#l2.16 - when ENABLE_SHARED_ARRAY_BUFFER isn't defined, it's a switch with no cases, only default, and MSVC says https://treeherder.mozilla.org/logviewer.html#?job_id=15773852&repo=try#L25501 "switch statement contains 'default' but no 'case' labels" and halts and catches fire.
|
Assignee | |
Comment 1•9 years ago
|
||
Ah, that reminds me - ENABLE_SHARED_ARRAY_BUFFER should no longer be Nightly-only!
|
|
Assignee | |
Comment 2•9 years ago
|
||
Attachment #8710893 -
Flags: review?(bbouvier)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8710893 [details] [diff] [review]
avoid default-only switch to placate MSVC
Review of attachment 8710893 [details] [diff] [review]:
-----------------------------------------------------------------
msvc being the witty one, fun!
Attachment #8710893 -
Flags: review?(bbouvier) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c94ef992148247f672b560380b6b2785f21a8ab1
Bug 1241767 - avoid default-only switch to placate MSVC. r=bbouvier
|
Reporter | |
Comment 5•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•