Closed Bug 1241767 Opened 5 years ago Closed 5 years ago

Patch from bug 1239605 will burn Windows builds on mozilla-aurora on 2016-01-25

Categories

(Core :: JavaScript Engine, defect)

All
Windows Server 2008
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: philor, Assigned: lth)

References

Details

Attachments

(1 file)

http://hg.mozilla.org/mozilla-central/rev/56c5187a2c64#l2.16 - when ENABLE_SHARED_ARRAY_BUFFER isn't defined, it's a switch with no cases, only default, and MSVC says https://treeherder.mozilla.org/logviewer.html#?job_id=15773852&repo=try#L25501 "switch statement contains 'default' but no 'case' labels" and halts and catches fire.
Ah, that reminds me - ENABLE_SHARED_ARRAY_BUFFER should no longer be Nightly-only!
Attachment #8710893 - Flags: review?(bbouvier)
Comment on attachment 8710893 [details] [diff] [review]
avoid default-only switch to placate MSVC

Review of attachment 8710893 [details] [diff] [review]:
-----------------------------------------------------------------

msvc being the witty one, fun!
Attachment #8710893 - Flags: review?(bbouvier) → review+
https://hg.mozilla.org/mozilla-central/rev/c94ef9921482
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.