1241769 - Use Singleton pattern to nsScreenManagerGonk

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Sotaro Ikeda [:sotaro]]

It seems nice to apply Singleton pattern to nsScreenManagerGonk that is used like AudioManager.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use Singleton pattern to nsScreenManagerGonk

Comment 2

[Michael Wu [:mwu]]

Comment on attachment 8710878 [details] [diff] [review]
patch - Use Singleton pattern to nsScreenManagerGonk

Review of attachment 8710878 [details] [diff] [review]:
-----------------------------------------------------------------

It does make more sense to do it this way, though a bit unfortunate that more code is required and we can't reuse the do_GetService logic.

::: widget/gonk/nsScreenManagerGonk.cpp
@@ +766,4 @@
>  /* static */ already_AddRefed<nsScreenManagerGonk>
>  nsScreenManagerGonk::GetInstance()
>  {
> +  MOZ_ASSERT(NS_IsMainThread());

This file is 4 space indent, so this function should be too.

@@ +767,5 @@
>  nsScreenManagerGonk::GetInstance()
>  {
> +  MOZ_ASSERT(NS_IsMainThread());
> +
> +  // Avoid createing nsScreenManagerGonk from content process.

nit: s/createing/creating/

@@ +772,5 @@
> +  if (!XRE_IsParentProcess()) {
> +    MOZ_CRASH("Non-chrome processes should not get here.");
> +  }
> +
> +  // Avoid createing multiple nsScreenManagerGonk instance inside main process.

nit: s/createing/creating/

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use Singleton pattern to nsScreenManagerGonk

Apply the comment. Carry "r=mwu".

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5665bf204fe3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5665bf204fe3