1241771 - Print install manifest processing time

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

Install manifest processing can eat up a lot of time. Let's print how long each one takes.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1241771 - Print install manifest processing time; r?glandium

Review commit: https://reviewboard.mozilla.org/r/31897/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/31897/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8710880 [details]
MozReview Request: Bug 1241771 - Print install manifest processing time; r?glandium

https://reviewboard.mozilla.org/r/31897/#review28619

::: python/mozbuild/mozbuild/action/process_install_manifest.py:24
(Diff revision 1)
> -COMPLETE = 'From {dest}: Kept {existing} existing; Added/updated {updated}; ' \
> +COMPLETE = 'Elapsed: {elapsed:.2f}s; From {dest}: Kept {existing} existing; ' \

Considering install manifests are IO bound and happen in parallel, influencing each other, I'm not convinced by the usefulness of those numbers. But meh. I'd put them at the end of the line, though.

Comment 3

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/31897/#review28619

> Considering install manifests are IO bound and happen in parallel, influencing each other, I'm not convinced by the usefulness of those numbers. But meh. I'd put them at the end of the line, though.

I put at beginning so output lines up nicely. Your response in IRC was "meh," so I'm landing this as is :)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb5a01dc56fb

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cb5a01dc56fb