Closed Bug 1241771 Opened 5 years ago Closed 5 years ago

Print install manifest processing time

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(1 file)

Install manifest processing can eat up a lot of time. Let's print how long each one takes.
Comment on attachment 8710880 [details]
MozReview Request: Bug 1241771 - Print install manifest processing time; r?glandium

https://reviewboard.mozilla.org/r/31897/#review28619

::: python/mozbuild/mozbuild/action/process_install_manifest.py:24
(Diff revision 1)
> -COMPLETE = 'From {dest}: Kept {existing} existing; Added/updated {updated}; ' \
> +COMPLETE = 'Elapsed: {elapsed:.2f}s; From {dest}: Kept {existing} existing; ' \

Considering install manifests are IO bound and happen in parallel, influencing each other, I'm not convinced by the usefulness of those numbers. But meh. I'd put them at the end of the line, though.
Attachment #8710880 - Flags: review?(mh+mozilla) → review+
https://reviewboard.mozilla.org/r/31897/#review28619

> Considering install manifests are IO bound and happen in parallel, influencing each other, I'm not convinced by the usefulness of those numbers. But meh. I'd put them at the end of the line, though.

I put at beginning so output lines up nicely. Your response in IRC was "meh," so I'm landing this as is :)
https://hg.mozilla.org/mozilla-central/rev/cb5a01dc56fb
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.