Closed Bug 1241806 Opened 9 years ago Closed 9 years ago

Make use of Preferences.jsm for getting and setting preferences

Categories

(Testing :: Firefox UI Tests, defect)

Product:
Testing
Component:
Firefox UI Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: whimboo, Unassigned, Mentored)

References

(
URL
)

Details

(Whiteboard: [lang=py])

Similar to bug 1240576 we should rework our code which handles getting and setting of preferences in Firefox. The Preferences.jsm module is really pretty nice and can simplify a lot. Here some examples: https://hg.mozilla.org/mozilla-central/rev/939930dcd555#l3.17 Source code: http://mxr.mozilla.org/mozilla-central/source/toolkit/modules/Preferences.jsm And here our prefs module which would need that update: https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_puppeteer/firefox_puppeteer/api/prefs.py Beside the update also the existent unit tests would have to be updated: https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_ui_tests/firefox_ui_tests/puppeteer/test_prefs.py
Mentor: hskupin
Whiteboard: [lang=py][good first bug]
Maybe we can even rely on Marionette here which now has set_pref(), get_pref(), and clear_pref() as it can be seen by the above referenced Marionette patch.
Hello, I just got my development environment set up following this guide, https://developer.mozilla.org/en-US/docs/Simple_Firefox_build I am now looking for a good first bug preferably with a mentor and if this bug is available I would like to take a crack at it :)
Hi Tanner, you are welcome to take this bug. No-one else expressed interest on it since it got filed lately. I will assign it to you once a first patch has been uploaded. Keep in mind that for now we still work with the github repository as primary source. This is mainly for getting changes tested via Travis CI. So please check out this URL which I also pasted in the URL field now. Let me know if you have questions. Btw you can also find me on IRC (irc.mozilla.org) in the #automation channel.
URL: https://github.com/mozilla/firefox-ui...
Hi! I'd like to work on this bug.
Hi Shruti. Tanner hasn't been replied yet. So please see comment 3 in how to get started.
Sorry about the late reply guys, I am stuck on a different bug at the moment so please feel free to take it I am still very new and familiarizing myself with Mozilla code.
Just to note... our tests have been moved into mozilla-central. The same applies to firefox-puppeteer which can be found here now: http://mxr.mozilla.org/mozilla-central/source/testing/puppeteer/firefox/firefox_puppeteer/
So here all relevant information to get this bug fixed: The file which actually needs the changes according to comment 0: http://mxr.mozilla.org/mozilla-central/source/testing/puppeteer/firefox/firefox_puppeteer/api/prefs.py I don't see that we would have to make changes to our tests which are located here (given that the changes shouldn't cause API changes): http://mxr.mozilla.org/mozilla-central/source/testing/firefox-ui/tests/firefox_ui_tests/ When changes have been made to the prefs.py file, ensure that all the tests are still working by executing "./mach firefox-ui-test" in a terminal in the root of your mozilla-central checkout.
URL: https://github.com/mozilla/firefox-ui...
I would like to work on this bug. Can you please assign it to me?
Someone else (sv on IRC) started to work on this bug. I should have mentioned that comment has to be made. In case we do no hear back until end of next week feel free to grab this bug. For now I would propose you find something else?
Sambuddha, I haven't heard back from sv on IRC. If you are still interested in this bug feel free to grab it. As we noticed it might not be such a easy bug. So I will remove the good first bug whiteboard entry.
URL: https://developer.mozilla.org/en-US/d...
Whiteboard: [lang=py][good first bug] → [lang=py]
With the project on bug 1293588 we want to make use of the preferences setters and getters from Marionette directly. So this bug is no longer needed.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.