Closed Bug 1241918 Opened 4 years ago Closed 4 years ago

Upstream Skia fixed zero-length dash intervals so we no longer need workarounds in HelpersSkia.h

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: lsalzman, Assigned: lsalzman)

Details

Attachments

(1 file)

Skia patched it here: https://codereview.chromium.org/1314213002
Blink had a long-standing bug against this here: https://code.google.com/p/chromium/issues/detail?id=422974

In any case, this was fixed before we updated Skia, so the fix is in our tree already. I did some testing and we should be good to go just removing our hacks for it.
Tested to make sure we're still okay on our unit tests with this gone, and all the upstream info indicates we should be fine as well.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d12eb330be68
Attachment #8711030 - Flags: review?(jmuizelaar)
Attachment #8711030 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/90a2e74d14ca
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.