Closed
Bug 1241956
Opened 8 years ago
Closed 8 years ago
Use standard license boilerplate in webconsole files
Categories
(DevTools :: Console, defect)
DevTools
Console
Tracking
(firefox46 affected, firefox47 fixed)
RESOLVED
FIXED
Firefox 47
People
(Reporter: linclark, Assigned: linclark)
References
Details
Attachments
(2 files, 2 obsolete files)
217.14 KB,
patch
|
Details | Diff | Splinter Review | |
9.58 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
See Bug 1241947
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → lclark
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•8 years ago
|
||
This patch just does the tests, since it's most important to get the change made to those. Since it was a comment that broke tests, I went ahead and pushed to try even though this shouldn't change any functionality. Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=719ae23f774c
Attachment #8711187 -
Flags: review?(bgrinstead)
Comment 2•8 years ago
|
||
Comment on attachment 8711187 [details] [diff] [review] Bug1241956.patch Review of attachment 8711187 [details] [diff] [review]: ----------------------------------------------------------------- Looks great, thanks! Please update commit message to say 'webconsole test files' or similar
Attachment #8711187 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Thanks for the review!
Attachment #8711187 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 4•8 years ago
|
||
Patch doesn't apply. Please rebase on top of fx-team tip.
Keywords: checkin-needed
Assignee | ||
Comment 5•8 years ago
|
||
Re-rolled. The conflict was the jsterm_scroll test.
Attachment #8711211 -
Attachment is obsolete: true
Assignee | ||
Comment 6•8 years ago
|
||
Here are the license updates in the additional files.
Attachment #8711676 -
Flags: review?(bgrinstead)
Comment 7•8 years ago
|
||
Comment on attachment 8711676 [details] [diff] [review] Bug1241956-2.patch Review of attachment 8711676 [details] [diff] [review]: ----------------------------------------------------------------- I'll land the rebased versions once this try push comes back: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb0a21a90873
Attachment #8711676 -
Flags: review?(bgrinstead) → review+
Comment 8•8 years ago
|
||
The only thing I'm seeing in the push is a simple error in browser_webconsole_bug_646025_console_file_location.js due to some line number changes. I've got a fix locally so I'll push it with that change.
https://hg.mozilla.org/integration/fx-team/rev/7fb47f96ae3c https://hg.mozilla.org/integration/fx-team/rev/415edbd4f1f9
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7fb47f96ae3c https://hg.mozilla.org/mozilla-central/rev/415edbd4f1f9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•