toggle text zoom menuitem state not in sync between the main menu and appmenu

RESOLVED FIXED in Thunderbird 46.0

Status

Thunderbird
Toolbars and Tabs
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({polish})

Trunk
Thunderbird 46.0
polish

Thunderbird Tracking Flags

(thunderbird45 fixed, thunderbird46 fixed)

Details

Attachments

(1 attachment)

2.05 KB, patch
Magnus Melin
: review+
Jorg K [Almost not working on Thunderbird (some bustage-fix only) due to non-renewal of contract]
: approval-comm-aurora+
Details | Diff | Splinter Review
(Assignee)

Description

2 years ago
"Toggle text zoom" menuitem state is not in sync between the main menu and appmenu version of the item.

STR:
1.in the main menu, use View->Zoom->Zoom text only
2.observe that in appmenu -> View-> Zoom->Zoom text only does not have the same state of the checkmark.
(Assignee)

Comment 1

2 years ago
Created attachment 8711102 [details] [diff] [review]
patch
Attachment #8711102 - Flags: review?(mkmelin+mozilla)

Comment 2

2 years ago
Comment on attachment 8711102 [details] [diff] [review]
patch

Review of attachment 8711102 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mailWindow.js
@@ +499,5 @@
>  }
>  
>  /** Update state of zoom type (text vs. full) menu item. */
>  function UpdateFullZoomMenu() {
> +  var menuItem = document.getElementById("cmd_fullZoomToggle");

please update the name to something like cmdItem
Attachment #8711102 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 3

2 years ago
Done, thanks.

Checked in:
https://hg.mozilla.org/comm-central/rev/4189fa7497f7
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
(Assignee)

Comment 4

2 years ago
Comment on attachment 8711102 [details] [diff] [review]
patch

This could go into TB45 as a polishing measure if we want.
Attachment #8711102 - Flags: approval-comm-aurora?
Attachment #8711102 - Flags: approval-comm-aurora? → approval-comm-aurora+
Aurora:
https://hg.mozilla.org/releases/comm-aurora/rev/c3d53b5ddf1e
status-thunderbird45: --- → fixed
status-thunderbird46: --- → fixed
You need to log in before you can comment on or make changes to this bug.