Closed
Bug 1241962
Opened 8 years ago
Closed 8 years ago
toggle text zoom menuitem state not in sync between the main menu and appmenu
Categories
(Thunderbird :: Toolbars and Tabs, defect)
Thunderbird
Toolbars and Tabs
Tracking
(thunderbird45 fixed, thunderbird46 fixed)
RESOLVED
FIXED
Thunderbird 46.0
People
(Reporter: aceman, Assigned: aceman)
Details
(Keywords: polish)
Attachments
(1 file)
2.05 KB,
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
"Toggle text zoom" menuitem state is not in sync between the main menu and appmenu version of the item. STR: 1.in the main menu, use View->Zoom->Zoom text only 2.observe that in appmenu -> View-> Zoom->Zoom text only does not have the same state of the checkmark.
Attachment #8711102 -
Flags: review?(mkmelin+mozilla)
Comment 2•8 years ago
|
||
Comment on attachment 8711102 [details] [diff] [review] patch Review of attachment 8711102 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/base/content/mailWindow.js @@ +499,5 @@ > } > > /** Update state of zoom type (text vs. full) menu item. */ > function UpdateFullZoomMenu() { > + var menuItem = document.getElementById("cmd_fullZoomToggle"); please update the name to something like cmdItem
Attachment #8711102 -
Flags: review?(mkmelin+mozilla) → review+
Done, thanks. Checked in: https://hg.mozilla.org/comm-central/rev/4189fa7497f7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
Comment on attachment 8711102 [details] [diff] [review] patch This could go into TB45 as a polishing measure if we want.
Attachment #8711102 -
Flags: approval-comm-aurora?
Updated•8 years ago
|
Attachment #8711102 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 5•8 years ago
|
||
Aurora: https://hg.mozilla.org/releases/comm-aurora/rev/c3d53b5ddf1e
status-thunderbird45:
--- → fixed
status-thunderbird46:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•