Closed Bug 1241970 Opened 8 years ago Closed 8 years ago

Survey Gizmo Beacon is controlled by waffle

Categories

(support.mozilla.org :: General, defect)

Product:
support.mozilla.org
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mythmon, Assigned: mythmon)

References

Details

(Whiteboard: u=admin p=1) 

In bug 1215607 we agreed to an implementation of Survey Gizmo beacons. In writing the code for that bug, I got the details wrong. In particular, these two lines:

* All KB pages associated with the Firefox product (product pages, topic pages, and document pages) should get the beacon survey.
* All KB pages associated with the Android ("mobile") product (product pages, topic pages, and document pages) should get the "mobile" survey, controlled by waffle.

The key part is that the first one is not controlled by waffle, and the second one is. In practice, the code makes both versions controlled by waffle, which is incorrect.
PR: https://github.com/mozilla/kitsune/pull/2778
Assignee: nobody → mcooper
Status: NEW → ASSIGNED
The PR has been merged in January already. Can we mark this as resolved, or was there something missing to actually fix the issue?
Flags: needinfo?(mcooper)
Oops, this bug got missed. Thanks for catching this Michal.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(mcooper)
Resolution: --- → FIXED
See Also: → 1300821
You need to log in before you can comment on or make changes to this bug.