Closed Bug 1241974 Opened 4 years ago Closed 4 years ago

Remove testing/mochitest/manifests/Makefile.in

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: mshal, Assigned: mshal)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Comment on attachment 8711108 [details] [diff] [review]
0001-Bug-1241974-remove-testing-mochitest-manifests-Makef.patch

Review of attachment 8711108 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/manifests/moz.build
@@ +3,5 @@
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
> +
> +TESTING_FILES.testing.mochitest.manifests += [

This would add the only use of TESTING_FILES to a moz.build file in tree. TEST_HARNESS_FILES appears to be the same thing. I'm not sure what's up with that.
Oh, interesting. I just saw it in context.py and figured that's what I needed :). TESTING_FILES is just used as the basis for TESTING_JS_MODULES, maybe it should be removed? I'll refresh the patch with TEST_HARNESS_FILES.
Attachment #8711108 - Flags: review?(gps)
Now with the more widely used variable.

Can we kill TESTING_FILES by just making TEST_HARNESS_FILES a ContextDerivedTypedHierarchicalStringList and using that as the basis for TESTING_JS_MODULES? I don't quite grok the distinction between them yet.
Attachment #8711108 - Attachment is obsolete: true
Attachment #8711121 - Flags: review?(gps)
Comment on attachment 8711121 [details] [diff] [review]
0001-Bug-1241974-remove-testing-mochitest-manifests-Makef.patch

Review of attachment 8711121 [details] [diff] [review]:
-----------------------------------------------------------------

TESTING_FILES used to be TESTING_JS_MODULES and was renamed in 3a46c6381b0d. There certainly does appear to be room to merge TESTING_FILES with TEST_HARNESS_FILES. Sounds like a follow-up bug waiting to be filed :)
Attachment #8711121 - Flags: review?(gps) → review+
Filed bug 1242632.
https://hg.mozilla.org/mozilla-central/rev/03d8d969187a
https://hg.mozilla.org/mozilla-central/rev/c9753338a30d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Target Milestone: mozilla46 → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.