Closed Bug 1241985 Opened 8 years ago Closed 8 years ago

Add JSON schema support to the lua sandbox

Categories

(Cloud Services Graveyard :: Metrics: Pipeline, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: trink, Assigned: trink)

References

Details

      No description provided.
Points: --- → 3
Blocks: 1243524
Priority: P2 → P1
The wjelement library only supports version 3 of the json schema spec (the current proposed version is 4).  Fortunately there is a lot of overlap and v3 should be sufficient for our needs.  Taking the v3 path will have us up and and running this week; contributing v4 support back to the lib would add at a week or two.

Any objections to using v3 as our specification format?
Flags: needinfo?(spenrose)
(In reply to Mike Trinkala [:trink] from comment #1)
> The wjelement library only supports version 3 of the json schema spec (the
> current proposed version is 4).  Fortunately there is a lot of overlap and
> v3 should be sufficient for our needs.  Taking the v3 path will have us up
> and and running this week; contributing v4 support back to the lib would add
> at a week or two.
> 
> Any objections to using v3 as our specification format?

Probably not, but I should test it. I'll work on that now.
(In reply to Sam Penrose from comment #2)
> (In reply to Mike Trinkala [:trink] from comment #1)
> > The wjelement library only supports version 3 of the json schema spec (the
> > current proposed version is 4).  Fortunately there is a lot of overlap and
> > v3 should be sufficient for our needs.  Taking the v3 path will have us up
> > and and running this week; contributing v4 support back to the lib would add
> > at a week or two.
> > 
> > Any objections to using v3 as our specification format?
> 
> Probably not, but I should test it. I'll work on that now.

Easy downgrade; go ahead.
Flags: needinfo?(spenrose)
After working with the wjelement library today I am going to remove it from consideration as it would require a large investment in time to get it where we need it.  The good news is I found that rapidJSON has experimental JSON schema support (v4).  I have worked with this library in the past and was pleased/impressed.  The experimental status is low risk as it is well tested and basically fully compliant with the standard.
The work resides on the schema_validation branch it will be merged after the decoder work Bug 1249666 is complete 
https://github.com/mozilla-services/lua_sandbox/tree/schema_validation/docs/heka
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Cloud Services → Cloud Services Graveyard
You need to log in before you can comment on or make changes to this bug.