"Load More..." row in dominator trees should be styled differently

ASSIGNED
Assigned to

Status

()

Firefox
Developer Tools: Memory
P3
normal
ASSIGNED
2 years ago
16 days ago

People

(Reporter: jsantell, Assigned: deepesh910, Mentored, NeedInfo)

Tracking

(Blocks: 1 bug, {good-first-bug})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][lang=css][lang=js])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Created attachment 8711135 [details]
Screen Shot 2016-01-21 at 10.33.00 PM.png

Not sure how exactly, but atleast have a `pointer` cursor to make it look clicky.
Blocks: 1221506
Mentor: jsantell@mozilla.com
Has STR: --- → irrelevant
(Assignee)

Comment 1

2 years ago
I would like to fix this bug. However this would be my first bug and I have no idea if i have adequate knowledge to debug it . I would try my best howsoever. Please assign this bug to me .
(Assignee)

Updated

2 years ago
Flags: needinfo?(jsantell)

Updated

2 years ago
Assignee: nobody → deepesh910
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
Since this is my first bug , i need some help . Where do i exactly find the code which i have to de-bug ?please help.
The "load more" frame can be found in devtools/client/memory/components/dominator-tree.js -- the `.load-more` class can be styled in devtools/client/themes/memory.css
Flags: needinfo?(jsantell)

Comment 4

2 years ago
Hello Jordan,

I would like to work on this bug. I'll try to submit a patch as soon as I can.

Thank You.
[good first bug] whiteboard -> keyword mass change
Keywords: good-first-bug

Comment 6

a year ago
If this is still open I would love to work on this bug. Would it be possible to be assigned it?
I really want to give this a shot. Can I have this assigned?
Hi!

I uploaded a patch for this. 

I'm not sure if the .load-more class I implemented has the expected behavior,
if not, just let me know which properties are expected and I'll add them right away :)
Flags: needinfo?(jordan)
Comment hidden (mozreview-request)
Thank you for the patch! I'm not really sure of the status of this bug, pinging Greg who will have a better idea.
Flags: needinfo?(jordan) → needinfo?(gtatum)
(Reporter)

Updated

7 months ago
Attachment #8868356 - Flags: review?(jordan)

Comment 11

23 days ago
I would like to work on this bug as part of my university coursework. Please could I be assigned to it and given extra information? Thank you!

Comment 12

23 days ago
(In reply to Rayann Tedds from comment #11)
> I would like to work on this bug as part of my university coursework. Please
> could I be assigned to it and given extra information? Thank you!

Also, how do I actually get to review the bug - is there a HTML file to view or something?

Thank you!
Sorry, this fell of my radar. The existing attached patch may actually work for it (although by now it's a kind of stale). This tool is a bit on "maintenance mode" with only fixing regressions. If you're looking for some easy first patches we're actively working on perf.html for performance work in Firefox:

https://github.com/devtools-html/perf.html/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22
You need to log in before you can comment on or make changes to this bug.