1242004 - Skip -Xclang arguments when generating clang compilation database or YouCompleteMe config

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

clang based tools typically choke when they encounter a lot of -XClang
arguments, and since those args are passed to the cc1 driver they're
unnecessary for such tools anyways.

This helps people who have things like --enable-clang-plugin in their
mozconfig use clang based tools without having to remove these arguments
manually.

Comment 1

[(no longer active)]

Attachment: Skip -Xclang arguments when generating clang compilation database or YouCompleteMe config

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8711137 [details] [diff] [review]
Skip -Xclang arguments when generating clang compilation database or YouCompleteMe config

Review of attachment 8711137 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the below fixed.  you++ for the commit message!

::: python/mozbuild/mozbuild/compilation/util.py
@@ +35,5 @@
>      return build_vars
> +
> +def sanitize_cflags(flags):
> +    # We filter out -Xclang arguments as clang based tools typically choke on
> +    # passing these flags down to the clang driver.

I think it is slightly clearer to say:

"We filter out -Xclang ARG sequences as clang-based tools..."

The use of |saw_xclang| below was not immediately obvious here, since the comment wording suggested to me we are only filtering -Xclang, not the argument to -Xclang.  Inept reviewer?  Possibly! ;)

Comment 3

[(no longer active)]

Will do!

(FWIW, -Xclang just tells the clang driver driver to pass whatever comes after it to clang cc1.  For example, this:

clang -cc1 -foo -bar -baz

needs to be expressed as:

clang -Xclang -foo -Xclang -bar -Xclang -baz

when invoking the driver driver.  I'll mention this in the comment to make it super clear.)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d997a1ef360

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d997a1ef360