1242005 - gfx\vr\ovr_capi_dynamic.h(392): warning C4359: '<unnamed-tag>': Alignment specifier is less than actual alignment (8), and will be ignored.

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

This is causing build failures for me on Windows 10 (with warnings-as-errors enabled).

 0:55.64 c:\users\mozpdx\mozilla-central\gfx\vr\ovr_capi_dynamic.h(392): error C2220: warning treated as error - no 'object' file generated
 0:55.64 c:\users\mozpdx\mozilla-central\gfx\vr\ovr_capi_dynamic.h(392): warning C4359: '<unnamed-tag>': Alignment specifier is less than actual alignment (8), and will be ignored.
 0:55.64 c:\users\mozpdx\mozilla-central\gfx\vr\ovr_capi_dynamic.h(401): warning C4359: '<unnamed-tag>': Alignment specifier is less than actual alignment (8), and will be ignored.
 0:55.66 c:\users\mozpdx\mozilla-central\gfx\vr\ovr_capi_dynamic.h(412): warning C4359: '<unnamed-tag>': Alignment specifier is less than actual alignment (8), and will be ignored.
 0:55.66
 0:55.67 In the directory  /c/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/gfx/vr
 0:55.67 The following command failed to execute properly:
 0:55.69 c:/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/_virtualenv/Scripts/python.exe -m mozbuild.action.cl cl -FoUnified_cpp_gfx_vr0.obj -c -Ic:/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/dist/stl_wrappers -
DDEBUG=1 -DTRACING=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_
MSVC -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Ic:/Users/MOZPDX/mozilla-central/gfx/vr -Ic:/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/gfx/vr -Ic:/Users/MOZPDX/mozilla-central/gfx/thebes -Ic:
/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/ipc/ipdl/_ipdlheaders -Ic:/Users/MOZPDX/mozilla-central/ipc/chromium/src -Ic:/Users/MOZPDX/mozilla-central/ipc/glue -Ic:/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/
dist/include -Ic:/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/dist/include/nspr -Ic:/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/dist/include/nss -MD -FI c:/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/mozi
lla-config.h -DMOZILLA_CLIENT -TP -nologo -Wv:18 -Zc:sizedDealloc- -Zc:threadSafeInit- -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:IA32 -FS -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4800 -wd4819 -we4553 -GR- -Zi -Oy- -WX
-Ic:/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/dist/include/cairo -Fdgenerated.pdb c:/Users/MOZPDX/mozilla-central/obj-i686-pc-mingw32/gfx/vr/Unified_cpp_gfx_vr0.cpp
 0:55.70 c:/Users/MOZPDX/mozilla-central/config/rules.mk:967: recipe for target 'Unified_cpp_gfx_vr0.obj' failed
 0:55.70 mozmake.EXE[5]: *** [Unified_cpp_gfx_vr0.obj] Error 1
 0:55.70 c:/Users/MOZPDX/mozilla-central/config/recurse.mk:71: recipe for target 'gfx/vr/target' failed
 0:55.72 mozmake.EXE[4]: *** [gfx/vr/target] Error 2
 0:55.72 mozmake.EXE[4]: *** Waiting for unfinished jobs....
 0:57.35 Unified_cpp_media_imagecapture0.cpp
 0:57.36 dom_media_imagecapture.lib.desc
 1:00.00 Unified_cpp_dom_media_raw0.cpp
 1:00.02 dom_media_raw.lib.desc
 1:01.61 Unified_cpp_accessible_generic0.cpp
 1:01.64 accessible_generic.lib.desc
 1:01.72 c:/Users/MOZPDX/mozilla-central/config/recurse.mk:32: recipe for target 'compile' failed
 1:01.72 mozmake.EXE[3]: *** [compile] Error 2
 1:01.72 c:/Users/MOZPDX/mozilla-central/config/rules.mk:557: recipe for target 'default' failed
 1:01.72 mozmake.EXE[2]: *** [default] Error 2
 1:01.72 c:/Users/MOZPDX/mozilla-central/client.mk:396: recipe for target 'realbuild' failed
 1:01.74 mozmake.EXE[1]: *** [realbuild] Error 2
 1:01.74 client.mk:171: recipe for target 'build' failed
 1:01.74 mozmake.EXE: *** [build] Error 2
 1:01.77 17 compiler warnings present.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Oh, whoops - turns out my system is actually Windows 8.1.

Comment 3

[Gregory Szorc [:gps]]

This is blocking Visual Studio 2015, which I'd like to roll out in the current release cycle. A timely resolution (either fixing the warning or disabling warnings as errors as a band aid) would be appreciated.

Comment 4

[Gregory Szorc [:gps]]

Attachment: MozReview Request: Bug 1242005 - Disable C4359 to allow compilation on VS2015; r?kip

The proper fix is to fix the underlying problem. However, I haven't
touched C++ in months and I'm lazy. So I'm going for the quick fix
so Visual Studio 2015 rollout is unblocked.

Review commit: https://reviewboard.mozilla.org/r/39823/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/39823/

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8730377 [details]
MozReview Request: Bug 1242005 - Disable C4359 to allow compilation on VS2015; r?kip

https://reviewboard.mozilla.org/r/39823/#review36429

The file with the warning is using macros derived from the Oculus VR 0.8 SDK.  This is possibly fixed with the upcoming (not yet public) release of the SDK, which has better support for VS2015.  For now, disabling the warning in this case seems like the best option.

Comment 6

[Gregory Szorc [:gps]]

Thanks for the background info, Kip! I'll clone this bug to track removing the hack later.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b559b11d4d1

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7b559b11d4d1