1242010 - about:home redirect shows full URL

Status: RESOLVED DUPLICATE of bug 1240169

(Hello (Loop) :: Client, defect)

Description

[Sevaan Franks [:sevaan]]

We have made it so that when in an active Hello session about:newtab is replaced with about:home to hide a users top sites. However, the URL in the urlbar shows the full path to about home. It should simply say "about:home" instead.

The URL displayed instead is:

jar:file:///Applications/FirefoxNightly.app/Contents/Resources/browser/omni.ja!/chrome/browser/content/browser/abouthome/aboutHome.xhtml

Comment 1

[Ian Bicking (:ianbicking)]

Odd, I haven't seen this behavior

Comment 2

[Ed Lee :Mardak]

This seems to be a recent regression in the last couple days.

Comment 3

[Ed Lee :Mardak]

Actually not that recent.. last good nightly was on the 12th:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e790bba372f14241addda469a4bdb7ab00786ab3&tochange=531d1f6d1cde1182e9f7f9dff81a4fc5abc0a601

Comment 4

[Ed Lee :Mardak]

Could bug 1218996 have caused this? Before,  NewTabURL.override("about:home") would result in about:home opening and not showing the url, but now that results in jar:file:///Applications/FirefoxNightly.app/Contents/Resources/browser/omni.ja!/chrome/browser/content/browser/abouthome/aboutHome.xhtml showing.

Comment 5

[Olivier Yiptong [:oyiptong]]

Indeed, bug 1218996 introduced this. It's related to bug 1240169.

In this case, what happens is that AboutRedirector.cpp will find a URL, and see that it's not a chrome resource (it's "about:home"), and promptly set the loadflag to LOAD_REPLACE.

The resolution of LOAD_REPLACE leads to the file:// url.

The reason it was showing about:home before 1218996 was because it wasn't hitting the redirector twice:

https://dxr.mozilla.org/mozilla-central/rev/e7f7e3e691d1/browser/base/content/utilityOverlay.js

It was simply setting the browser URL to about:home, then the redirector would get the chrome url from the redirMap and find it's a resource, and use a LOAD_NORMAL loadflag

Comment 6

[Olivier Yiptong [:oyiptong]]

I'm currently mulling two possible solutions:

1. Figure out a way to load the URL's correctly in AboutRedirector.cpp
2. revert BROWSER_NEW_TAB_URL in utilityOverlay.js to it's previous behavior (i.e. skipping an trip to AboutRedirector.cpp). That will return the behavior to what it was

#2 is easy, but leaves the behavior incorrect for someone typing "about:newtab" in the url bar. Either way, I'll land a solution before merge date.

Comment 7

[Olivier Yiptong [:oyiptong]]

Ok. got a patch ready. I'm marking this as a duplicate of the other bug