Regularize SpiderMonkey's include guards again

ASSIGNED
Assigned to

Status

()

Core
JavaScript Engine
ASSIGNED
2 years ago
2 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(firefox46 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8711151 [details] [diff] [review]
regularize_header_include_guards-v0.diff
Attachment #8711151 - Flags: review?(jorendorff)
(Assignee)

Comment 1

2 years ago
I found these using the following script:

'''bash
#!/bin/bash
FILES=`find . -name "*.h" | grep -v irreg | grep -v libffi | grep -v vixl | grep -v editline | grep -v vtune | grep -v style | grep -v llvm-compiler-rt`

for FILE in $FILES; do
    GUARDNAME=`sed -n "s/#ifndef \(.*_h\)$/\1/p" ${FILE}`
    if [ -z $GUARDNAME ]; then
        echo "Missing guard in: "$FILE
    fi
done
'''
(Assignee)

Comment 2

2 years ago
Note: there are probably more wrong-style include guards, but I care less about those.
(Assignee)

Updated

2 years ago
Blocks: 1242045
(Assignee)

Updated

2 years ago
Component: JavaScript: GC → JavaScript Engine
(In reply to Terrence Cole [:terrence] from comment #1)
> I found these using the following script:

Nice!  

Is it possible to add a check like this to check_spidermonkey_style.py?
Attachment #8711151 - Flags: review?(jorendorff) → review+
You need to log in before you can comment on or make changes to this bug.