Open
Bug 1242026
Opened 8 years ago
Updated 2 years ago
Regularize SpiderMonkey's include guards again
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox46 | --- | affected |
People
(Reporter: terrence, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
7.83 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8711151 -
Flags: review?(jorendorff)
Reporter | ||
Comment 1•8 years ago
|
||
I found these using the following script: '''bash #!/bin/bash FILES=`find . -name "*.h" | grep -v irreg | grep -v libffi | grep -v vixl | grep -v editline | grep -v vtune | grep -v style | grep -v llvm-compiler-rt` for FILE in $FILES; do GUARDNAME=`sed -n "s/#ifndef \(.*_h\)$/\1/p" ${FILE}` if [ -z $GUARDNAME ]; then echo "Missing guard in: "$FILE fi done '''
Reporter | ||
Comment 2•8 years ago
|
||
Note: there are probably more wrong-style include guards, but I care less about those.
Reporter | ||
Updated•8 years ago
|
Component: JavaScript: GC → JavaScript Engine
Comment 3•8 years ago
|
||
(In reply to Terrence Cole [:terrence] from comment #1) > I found these using the following script: Nice! Is it possible to add a check like this to check_spidermonkey_style.py?
Updated•8 years ago
|
Attachment #8711151 -
Flags: review?(jorendorff) → review+
Updated•3 years ago
|
Assignee: terrence.d.cole → nobody
Status: ASSIGNED → NEW
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•