1242026 - Regularize SpiderMonkey's include guards again

Status: NEW

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: regularize_header_include_guards-v0.diff

Comment 1

[Terrence Cole [:terrence]]

I found these using the following script:

'''bash
#!/bin/bash
FILES=`find . -name "*.h" | grep -v irreg | grep -v libffi | grep -v vixl | grep -v editline | grep -v vtune | grep -v style | grep -v llvm-compiler-rt`

for FILE in $FILES; do
    GUARDNAME=`sed -n "s/#ifndef \(.*_h\)$/\1/p" ${FILE}`
    if [ -z $GUARDNAME ]; then
        echo "Missing guard in: "$FILE
    fi
done
'''

Comment 2

[Terrence Cole [:terrence]]

Note: there are probably more wrong-style include guards, but I care less about those.

Comment 3

[Jon Coppeard (:jonco) (PTO until 14th September)]

(In reply to Terrence Cole [:terrence] from comment #1)
> I found these using the following script:

Nice!  

Is it possible to add a check like this to check_spidermonkey_style.py?